Skip to content

2022.2 #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 3, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/qiita-plugin-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,9 @@ jobs:
- name: Install Qiita plugins
shell: bash -l {0}
run: |
wget --quiet https://data.qiime2.org/distro/core/qiime2-2021.11-py38-linux-conda.yml
conda env create -n qiime2 --quiet --file qiime2-2021.11-py38-linux-conda.yml
rm qiime2-2021.11-py38-linux-conda.yml
wget --quiet https://data.qiime2.org/distro/core/qiime2-2022.2-py38-linux-conda.yml
conda env create -n qiime2 --quiet --file qiime2-2022.2-py38-linux-conda.yml
rm qiime2-2022.2-py38-linux-conda.yml

conda activate qiime2

Expand Down
89 changes: 60 additions & 29 deletions qp_qiime2/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,9 @@
qiita_artifact = 'BIOM'

if q2plugin.name not in Q2_ALLOWED_PLUGINS:
# As of qiime2-2021.2 this filters out:
# As of qiime2-2022.2 this filters out:
# alignment
# diversity-lib
# empress
# feature-classifier
# fragment-insertion
# quality-control
Expand Down Expand Up @@ -120,6 +120,15 @@
qt_name, predicate = get_qiime2_type_name_and_predicate(element)

if qt_name not in Q2_QIITA_SEMANTIC_TYPE:
# As of qiime2-2022.2 this filters out:
# Hierarchy
# gneiss dendrogram_heatmap
# gneiss ilr_hierarchical
# SampleEstimator
# sample-classifier predict_classification
# sample-classifier predict_regression
# ProcrustesStatistics
# emperor procrustes_plot
add_method = False
break

Expand All @@ -142,6 +151,14 @@
req_params[element.description] = ('artifact', ['BIOM'])
to_delete.append(pname)
else:
# As of qiime2-2022.2 this filters out:
# predicate: Importance
# importance heatmap
# importances plot_feature_volatility
# predicate: Differential
# differential ilr_phylogenetic_differential
# predicate: AlignedSequence | Sequence
# data tabulate_seqs
add_method = False
elif etype == 'TaxonomicClassifier':
default = qp_qiime2_dbs[0]
Expand All @@ -155,7 +172,10 @@
# this is an odd one, first encountered:
# feature-classifier fit-classifier-naive-bayes
if ename == element.NOVALUE:
add_method = False
# As of qiime2-2022.2 nothing is filtered here, so let's raise
# an error so we can catch and review if this happens in the
# future
raise ValueError(f"[REVIEW] {pname} {mid} due to {ename}")
else:
req_params[ename] = ('artifact', [etype])
req_params['qp-hide-param' + ename] = ('string', pname)
Expand All @@ -169,6 +189,28 @@
qt_name, predicate = get_qiime2_type_name_and_predicate(element)
if (qt_name not in Q2_QIITA_SEMANTIC_TYPE or
qt_name in NOT_VALID_OUTPUTS):
# As of qiime2-2022.2 this filters out:
# Hierarchy
# gneiss assign_ids
# gneiss correlation_clustering
# gneiss gradient_clustering
# gneiss ilr_phylogenetic
# Phylogeny
# gneiss ilr_phylogenetic_differential
# gneiss ilr_phylogenetic_ordination
# phylogeny align_to_tree_mafft_fasttree
# phylogeny align_to_tree_mafft_iqtree
# phylogeny align_to_tree_mafft_raxml
# phylogeny filter_tree
# SampleEstimator
# longitudinal feature_volatility
# longitudinal maturity_index
# sample-classifier classify_samples
# sample-classifier fit_classifier
# sample-classifier fit_regressor
# sample-classifier regress_samples
# ProcrustesStatistics
# diversity procrustes_analysis
add_method = False
break
else:
Expand All @@ -180,32 +222,21 @@
if qname == 'feature-classifier' and mid == 'classify_sklearn':
outputs_params['Feature Table with Classification'] = 'BIOM'

if len(inputs) != 1 or not add_method:
# As of qiime2-2021.2 this filters out:
# sample-classifier fit_regressor
# sample-classifier predict_regression
# sample-classifier regress_samples
# sample-classifier fit_classifier
# sample-classifier predict_classification
# sample-classifier classify_samples
# longitudinal feature_volatility
# longitudinal maturity_index
# gneiss assign_ids
# gneiss ilr_phylogenetic
# gneiss correlation_clustering
# gneiss dendrogram_heatmap
# gneiss ilr_hierarchical
# gneiss gradient_clustering
# gneiss gradient_clustering
# diversity pcoa_biplot
# diversity mantel
# emperor procrustes_plot
# diversity pcoa_biplot
# diversity procrustes_analysis
# gneiss assign_ids
# gneiss ilr_phylogenetic
# gneiss ilr_phylogenetic_differential
# taxa filter_seqs
if not add_method:
# for details of which commands are filtered due to this flag check
# the code above
continue

total_inputs = len(inputs)
if total_inputs == 0:
# As of qiime2-2022.2 this filters out:
# filtered_sequences filter_seqs
continue
elif total_inputs > 1:
# As of qiime2-2022.2 this filters out:
# 2
# biplot pcoa_biplot
# visualization mantel
continue

for pname, element in parameters.items():
Expand Down