Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge from master. #1

Merged
merged 145 commits into from
Aug 15, 2019
Merged

merge from master. #1

merged 145 commits into from
Aug 15, 2019

Conversation

qingyhe
Copy link
Owner

@qingyhe qingyhe commented Aug 15, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

Zim Kalinowski and others added 30 commits July 31, 2019 21:02
…pe to enum, this will bring breaking change in java sdk. Solution: remove the two enum, change it to string type (#6785)
- Add "body" for RESPONSE_BODY_NOT_IN_EXAMPLE errors
- Remove responses for 202s with no schema defined for RESPONSE_SCHEMA_NOT_IN_SPEC errrors
- The OBJECT_ADDITIONAL_PROPERTIES are not addressed
- "Thumbprint" -> "thumbprint"
* Use previous swagger as base

* Add new API version 2019-08-01
…#6766)

* Set IoTSecuritySolutions & IoTSecuritySolutionAnalytics API as stable

* Set IoTSecuritySolutions & IoTSecuritySolutionAnalytics API as stable

* remove example from file names

* remove paging support from IoTSecurityDeviceRecommendationsList

* remove paging from IoTSecurityAlertedDevicesList
* Update the possible Kind values to include FHIR R4

* Fix type in description, adding Apis

* Fix fhir kind enum description to mention new values

* Update title to include Apis
* next link in alerst management

* Update specification/alertsmanagement/resource-manager/Microsoft.AlertsManagement/preview/2018-05-05-preview/examples/SmartGroups_List.json

thanks @nschonni !

Co-Authored-By: Nick Schonning <nschonni@gmail.com>
Add "body" for RESPONSE_BODY_NOT_IN_EXAMPLE errors
…preview/2019-04-01 (#6731)

* Task 4957070: ARM swagger update to include term in get reservation response.

* Task 4957070: ARM swagger update to include term in get reservation response.
- Add "body" for RESPONSE_BODY_NOT_IN_EXAMPLE error
- "AclStatus" -> "aclStatus"
* Began organizing and preparing for release

* Added Necessary supression

* Small bugfix

* Update version in new swagger file

* Added Go Support

* Added preview specification in generated paths
Remove "body" for RESPONSE_SCHEMA_NOT_IN_SPEC errors
Fix spelling issues added in #6629 from "example" values in spec
* fix: Microsoft.Sql/stable/2014-04-01 model validation

- RESPONSE_SCHEMA_NOT_IN_SPEC
- RESPONSE_BODY_NOT_IN_EXAMPLE
- Remove "description" not it schema
Other issues not resolved

* fix: sql preview model validation errors

- Remove empty "body" for RESPONSE_SCHEMA_NOT_IN_SPEC errors
- IsAzureMonitorTargetEnabled -> isAzureMonitorTargetEnabled
- "State" -> "state"
- emailAccountAdmins "true" -> true
- Add 202 response for RestorePoints_Create
- password -> certPassword for ManagedInstanceTdeCertificates_Create and TdeCertificates_Create
…6767)

* Re-enable v1 CI pipeline and retarget v2 sdk automation to test repo
Remove empty body for RESPONSE_SCHEMA_NOT_IN_SPEC errors
Remove empty body for RESPONSE_SCHEMA_NOT_IN_SPEC errors
* add QnAMaker runtime to Go SDK

* ensure package directory and namespace match
Remove empty "body" to fix RESPONSE_SCHEMA_NOT_IN_SPEC errors
* add TriggerRuns_Rerun api

* pr update

* update example
ArcturusZhang and others added 29 commits August 13, 2019 12:47
* Create AzureMachineLearning.json

Initial version of data plane swagger.

* Fix typos and semantic issues identified by checks

Removed duplicate operation ids
fixed typos

* Remove extraneous comma

Removed extraneous comma.

* Address code review comments.

* Removing x-ms-example attribute to pass model validation.

The Model Validation Job is failing for this PR and I am not sure why.  Attempting to remove the examples to see if that resolves the issue.

* Create readme.md

Added readme.md

* Add suppression for some errors/warnings

* Apply suggestions from code review

fix misspellings

Co-Authored-By: hendrytl <36863669+hendrytl@users.noreply.github.com>

* Removed suppressions until approved

* undo path casing changes; fix typos.

* Adding Approved suppressions

* Update AzureMachineLearning.json

Incorporate feedback from API Review Board:
make pagination consistent with nextlink
rename contracts to be more user friendly (remove DTO, etc.)
Fix file upload object type
Remove Stream and other C# datatypes

* Fix duplicate Id and add examples

Update example files to be references instead of inline.
Fixed duplicate Id.

* Update model management

rename some classes, add more documentation.

* Split swagger into component pieces

Separate the api into multiple components to facilitate easier review and management.

* Add suppression for camelCase

Added approved suppression for camelCase issue in hyperdrive.

* Add more examples for hyperdrive

fix tab to spaces.
remove required from runhistory host.

* Update example for hyperdrive

Was missing response details.

* updaing Artifacts swagger to add the xml comments for contracts

* Update artifact.json

* removing extra spaces

* spelling fix

* Addressing comments from Azure review board

* spelling corrections

* Round 3 Azure API Review comments addressed

* Adding custom words of AzureML Swaggers

* Hyperdrive structure correction

* Example File Corrections

* Change snake_case to camelCase and resolve comment

* Artifact, datastore, Runhistory, execution services updated

* updating swaggers

* updating swaggers

* Update MMS Swagger Json Patch

* updating execution swagger

* making version 2019-08-01

* Update readme.md

* Update cancelRunWithUri.json

* Delete cancelRun.json

* Update startRun.json

* Update startLocalRun.json

* Update startSnapshotRun.json

* Update cancelHyperDriveExperiment.json

* Update createHyperDriveExperiment.json

* Update startLocalRun.json

* Update startLocalRun.json

* Update startLocalRun.json

* Update startLocalRun.json

* Update startLocalRun.json

* Update startLocalRun.json

* Update startLocalRun.json

* Update startLocalRun.json

* Update startLocalRun.json

* minor fix

* Add new custom words for AzureML DataPlane Rest APIs

* Update custom-words.txt

* disabling enum settings and mms updates

* Added HyperDrive prefix to policy definitions, removed unused definitions and made study_id optional.

* Add custom words from HyperDrive json
* Add swagger specification for firewall policy resource (#6708)

* Add swagger specification for firewall policy resource

* Add the firewall policy spec to the list of files in readme.md

* Add priority to the Filter Rule in example for Rule Group Get

* Encapsulate the response body in a body property

* Suppress errors due to missing properties inhertied from base resource:

* Fix typo

* Fix Build errors

* Address review comments

* Revert capitalization of Tags and OperationId as Semantic valiation expects lower case

* Drop 201 response from examples

* Capitalize first letter of the operationId and tags values

* Add swagger changes for azure firewall in vHub

* Add a ref to the example file for Azure Firewall in vHub

* Fix validation check

* Address review comments

* Fix typos in Network's examples (#6740)

* Add missing read-only property "loadBalancerFrontendIpConfiguration" to publicIpPrefix (#6693)

* Make patch operations async for VNGs and VNG Connections (#6695)

* fix: network 2019-06-01 model validation errror (#6790)

Thumbprint -> thumbprint

* Update definition of ApplicationGatewayOnDemandProbe (#6716)

* Fix definition of ApplicationGatewayOnDemandProbe

* minor changes

* Copy fixed examples to 2019-02-01
…olation (#6947)

* added support sample interpolation in swagger

* Fixed the model validation failure
* fix schema property naming

* remove redundent schema reference
- Remove empty body for RESPONSE_SCHEMA_NOT_IN_SPEC errors
- Wrapped headers for FileGetPropertiesFromNode.json
- leavingpool -> leavingPool
- targetDedicated -> targetDedicatedNodes
- currentDedicated -> currentDedicatedNodes
- Index is integer rather than a string
- Add "body" for RESPONSE_BODY_NOT_IN_EXAMPLE error
- start is an integer rather than a string
- count is an integer rather than a string
- Add missing 200 responses
* Adding swagger spec for unprepare subnet

* fixing display name for unprepare example

* Update custom-words.txt
* Swagger: Allowing for VMSS reference during VM creation

* fixing typo
* Add alertRuleTemplates endpoint to securityInsight

* update indentation

* fix merge conflict

* Bookmarks swagger updates

* fix typos

* fix typo

* run validation again. network problem
Remove null body and headers for RESPONSE_SCHEMA_NOT_IN_SPEC errors
@qingyhe qingyhe merged commit 95e1d19 into qingyhe:master Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.