Split-off the API client resources in an isolated sub-package #198
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This patch moves most of the resources associated to the Qiskit-agnostic API client to an isolated sub-package at
qiskit_aqt_provider.api_client
. The isolation is enforced by the newly configured tach setup.The realize the isolation, the
User-Agent
string now declares a different name for the client (i.e. not mentioningqiskit-aqt-provider
anymore). The remaining information stays the same.Follow-up work will include moving all Qiskit-agnostic resources to the
qiskit_aqt_provider.api_client
package as well as defining a clean public interface for that package (that is, enabletach
's strict mode forqiskit_aqt_provider.api_client
). This sub-package could then be published as an independent package.Details and comments
The
tach
setup also includes runningtach check-external
. This unfortunately has a number of issues:test
extra introduced in Add test dependency group #183. Those dependencies need to be manually excluded in thetach
configuration.tach check-external
as a pre-commit hook breaks because the package metadata is not available fortach
to understand thatpython_dotenv
is the distribution name for thedotenv
package. This will be fixed upstream.