This repository has been archived by the owner on Dec 7, 2021. It is now read-only.
Change base gate U3 to U #1351
Merged
Change base gate U3 to U #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cryoris
requested review from
levbishop,
manoelmarques,
pbark,
stefan-woerner and
woodsp-ibm
as code owners
woodsp-ibm
approved these changes
Oct 15, 2020
woodsp-ibm
added
the
Changelog: Bugfix
mtreinish
pushed a commit
to mtreinish/qiskit-core
that referenced
this pull request
Nov 20, 2020
* change base gate set from u3 to u * rm reno -- no user facing change * fix comment
manoelmarques
pushed a commit
to manoelmarques/qiskit-terra
that referenced
this pull request
Nov 23, 2020
* change base gate set from u3 to u * rm reno -- no user facing change * fix comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Merge after Qiskit/qiskit#5083 to fix Aqua's old basis gate set.
Replace basis gate set
u1 u2 u3 cxbyp u cx.Details and comments
As a follow-up to the deprecation of U1/U2/U3 and U as the base-gate that
cannot be decomposed further (instead of previously U3), change the base
gates from
u1 u2 u3top u. This resolves errors where we assumed onecould always unroll to
u3 cx, which now is not possible anymore asudoes not have a definition. Instead it is always possible to unroll to
u cx.