Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin torch==2.2.2 in CI to avoid a UTF-8 error in Windows (temporary bug in Torch) #796

Merged
merged 1 commit into from
May 2, 2024
Merged

Pin torch==2.2.2 in CI to avoid a UTF-8 error in Windows (temporary bug in Torch) #796

merged 1 commit into from
May 2, 2024

Conversation

edoaltamura
Copy link
Collaborator

@edoaltamura edoaltamura commented May 2, 2024 •
edited
Loading

Summary

Pins torch==2.2.2 in CI to avoid a UTF-8 error in Windows. This change is temporary and should be reverted to the latest Torch version as soon as the fix for pytorch/pytorch#124897 reflects in pypi.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8923126612

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.636%
Totals Coverage Status
Change from base Build 8333263574: 0.0%
Covered Lines: 1887
Relevant Lines: 2037
💛 - Coveralls

woodsp-ibm
woodsp-ibm approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@woodsp-ibm woodsp-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you want to create an issue to revert this change once a new release of torch is done that includes the fix so as we don;t forget to do this at some point,.

@edoaltamura edoaltamura mentioned this pull request May 2, 2024
Closed
@edoaltamura edoaltamura self-assigned this May 2, 2024
@edoaltamura edoaltamura added the type: ci 🔧 Related to Continuous Integration workflows label May 2, 2024
@edoaltamura edoaltamura merged commit f98a89c into qiskit-community:main May 2, 2024
18 checks passed
@woodsp-ibm woodsp-ibm mentioned this pull request May 10, 2024
Merged
@edoaltamura edoaltamura added the stable backport potential The bug might be minimal and/or import enough to be port to stable label May 13, 2024
mergify bot pushed a commit that referenced this pull request May 13, 2024
@edoaltamura @mergify
Pin torch==2.2.2 in CI to avoid a known error with 2.2.3 (#796)
9b06add 
(cherry picked from commit f98a89c)
@mergify mergify bot mentioned this pull request May 13, 2024
Closed
@edoaltamura edoaltamura added stable backport potential The bug might be minimal and/or import enough to be port to stable and removed stable backport potential The bug might be minimal and/or import enough to be port to stable labels May 13, 2024
@woodsp-ibm woodsp-ibm mentioned this pull request May 13, 2024
Merged
@edoaltamura edoaltamura mentioned this pull request Jul 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodsp-ibm woodsp-ibm woodsp-ibm approved these changes

@adekusar-drl adekusar-drl Awaiting requested review from adekusar-drl adekusar-drl is a code owner

@smens smens Awaiting requested review from smens smens is a code owner

@oscar-wallis oscar-wallis Awaiting requested review from oscar-wallis oscar-wallis is a code owner

@OkuyanBoga OkuyanBoga Awaiting requested review from OkuyanBoga OkuyanBoga is a code owner

@Benjamin-Symons Benjamin-Symons Awaiting requested review from Benjamin-Symons Benjamin-Symons is a code owner

Assignees

@edoaltamura edoaltamura

Labels
stable backport potential The bug might be minimal and/or import enough to be port to stable type: ci 🔧 Related to Continuous Integration workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edoaltamura @coveralls @woodsp-ibm