-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update black (backport #799) #800
Conversation
(cherry picked from commit 1d56c0a)
It seems the stable branch no longer builds:
|
Shall we temporarily backport #796 (and then backport the restored versioning for Torch later on) before backporting this PR? |
There are two failures in CI here that require fixes from two PRs, as listed above, applied together as can be seen from #802 which just backported one of them. The other I would be reluctant to backport now since the new CI builds it had added back then, were M1 images, and now as the other issue linked above related to CI and images notes the main Mac images are now M1 and no longer X86 as they always used to be so CI should be updated otherwise at present its running the same stuff twice. I had thought to do a PR direct to stable with both the test fix for M1 - it needs it here now in stable, since, as I mentioned above, the mac os latest image is M1 rather than X86 here (we never backported the M1 addition with the test fix) - and pin torch. Let me do that so CI passes. |
@edoaltamura I put the test fix and the torch pin in a PR #803. That should get stable running again and allow this PR to pass once its updated. Then #802, which backported just one of the changes of the two needed, can be simply closed. |
@Mergifyio update |
✅ Branch has been successfully updated |
This is still failing, despite #803 being merged that was set to fix this. It seems a new version of pylint has just been released which is finding a new issue with the lint check - the nightly build failed too so this needs sorting with a PR to main and that backporting when hopefully this will finally pass and be mergable. Update: I just created #804 to address the new lint failures. Once that is backported and merged to this PR it should finally go through! |
@Mergifyio update |
✅ Branch has been successfully updated |
Pull Request Test Coverage Report for Build 9105216597Details
💛 - Coveralls |
Summary
Updates black to latest version (older version had a potential denial of service attack)
Similar update to qiskit-community/qiskit-nature#1357
Details and comments
This is an automatic backport of pull request #799 done by [Mergify](https://mergify.com).