Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily skip broken tests #527

Merged
merged 2 commits into from
Feb 1, 2022
Merged

Temporarily skip broken tests #527

merged 2 commits into from
Feb 1, 2022

Conversation

mrossinek
Copy link
Member

@mrossinek mrossinek commented Feb 1, 2022 •
edited
Loading

Summary

Disables the tests which broke after Qiskit/qiskit#7551.

Details and comments

This is to be reverted once the occurrence of close-to-zero imaginary phases arising in the Z2Symmetry reduction code are handled properly within Qiskit Terra.

EDIT: PR in Terra which is supposed to fix this: Qiskit/qiskit#7598

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1777434110

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 12 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 82.241%
Files with Coverage Reduction New Missed Lines %
qiskit_nature/drivers/second_quantization/psi4d/psi4driver.py 2 86.47%
qiskit_nature/algorithms/excited_states_solvers/qeom.py 10 78.1%
Totals Coverage Status
Change from base Build 1757374199: -0.1%
Covered Lines: 8317
Relevant Lines: 10113
💛 - Coveralls

@manoelmarques
Copy link
Contributor

There is a decorator too @unittest.skip but since this is temporary, it is fine by me.

@mrossinek mrossinek merged commit dc5e19e into qiskit-community:main Feb 1, 2022
@mrossinek mrossinek deleted the skip_failing_tests branch February 1, 2022 13:39
Cryoris added a commit to Cryoris/qiskit-nature that referenced this pull request Feb 17, 2022
@Cryoris
Revert "Temporarily skip broken tests (qiskit-community#527)"
3aca1f9 
This reverts commit dc5e19e.
@Cryoris Cryoris mentioned this pull request Feb 17, 2022
Merged
mergify bot pushed a commit that referenced this pull request Feb 18, 2022
@Cryoris @mrossinek
Revert "Temporarily skip broken tests (#527)" (#566)
47eabdb 
* Revert "Temporarily skip broken tests (#527)"

This reverts commit dc5e19e.

* copyright

* copyright

* Trigger CI with run_slow

Co-authored-by: Max Rossmannek <oss@zurich.ibm.com>
Anthony-Gandon pushed a commit to Anthony-Gandon/qiskit-nature that referenced this pull request May 25, 2023
@mrossinek
Temporarily skip broken tests (qiskit-community#527)
4469e64 
* test: temporarily skip tests which broke after Qiskit/qiskit#7551

* Fix copyright
Anthony-Gandon pushed a commit to Anthony-Gandon/qiskit-nature that referenced this pull request May 25, 2023
@Cryoris @mrossinek
Revert "Temporarily skip broken tests (qiskit-community#527)" (qiskit…
81a5b6b 
…-community#566)

* Revert "Temporarily skip broken tests (qiskit-community#527)"

This reverts commit dc5e19e.

* copyright

* copyright

* Trigger CI with run_slow

Co-authored-by: Max Rossmannek <oss@zurich.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manoelmarques manoelmarques manoelmarques approved these changes

@pbark pbark Awaiting requested review from pbark

@stefan-woerner stefan-woerner Awaiting requested review from stefan-woerner

@woodsp-ibm woodsp-ibm Awaiting requested review from woodsp-ibm woodsp-ibm is a code owner

Assignees
No one assigned
Labels
priority: critical
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrossinek @coveralls @manoelmarques