Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Temporarily skip broken tests (#527)" #566

Merged
merged 4 commits into from
Feb 18, 2022
Merged

Revert "Temporarily skip broken tests (#527)" #566

merged 4 commits into from
Feb 18, 2022

Conversation

Cryoris
Copy link
Contributor

@Cryoris Cryoris commented Feb 17, 2022

Summary

Now that Qiskit/qiskit#7598 is merged, we can again enable the tests relying on Z2 symmetries which were temporarily skipped in #527.

Details and comments

woodsp-ibm
woodsp-ibm approved these changes Feb 17, 2022
View reviewed changes
Copy link
Member

@woodsp-ibm woodsp-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have the change/fix merged in Terra, thanks for re-enabling these again.

@coveralls
Copy link

coveralls commented Feb 17, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1863292474

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.08%) to 83.056%
Files with Coverage Reduction New Missed Lines %
qiskit_nature/drivers/second_quantization/psi4d/psi4driver.py 2 84.43%
Totals Coverage Status
Change from base Build 1848493109: 0.08%
Covered Lines: 8735
Relevant Lines: 10517
💛 - Coveralls

mrossinek
mrossinek approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@mrossinek mrossinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Since this re-enables some slow tests I will add the run_slow tag and trigger CI once to make sure everything is in order 👍

@mrossinek mrossinek added the run_slow PR will run all unit tests decorated as slow label Feb 18, 2022
@mergify mergify bot merged commit 47eabdb into qiskit-community:main Feb 18, 2022
Anthony-Gandon pushed a commit to Anthony-Gandon/qiskit-nature that referenced this pull request May 25, 2023
@Cryoris @mrossinek
Revert "Temporarily skip broken tests (qiskit-community#527)" (qiskit…
81a5b6b 
…-community#566)

* Revert "Temporarily skip broken tests (qiskit-community#527)"

This reverts commit dc5e19e.

* copyright

* copyright

* Trigger CI with run_slow

Co-authored-by: Max Rossmannek <oss@zurich.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodsp-ibm woodsp-ibm woodsp-ibm approved these changes

@mrossinek mrossinek mrossinek approved these changes

@stefan-woerner stefan-woerner Awaiting requested review from stefan-woerner

@pbark pbark Awaiting requested review from pbark

@manoelmarques manoelmarques Awaiting requested review from manoelmarques

Assignees
No one assigned
Labels
automerge run_slow PR will run all unit tests decorated as slow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Cryoris @coveralls @mrossinek @woodsp-ibm