Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capital letters not getting sent with sendstring_swiss_fr.h #20080

Closed
AndroSteph opened this issue Mar 10, 2023 · 4 comments
Closed

Capital letters not getting sent with sendstring_swiss_fr.h #20080

AndroSteph opened this issue Mar 10, 2023 · 4 comments

Comments

@AndroSteph
Copy link

Issue Description

Hello to all,

These times I ask questions that are surely basic for you programmer. But I like to understand and I come across misunderstandings and unfortunately it is very difficult to find answers on the WWW other than here (I have not found any tutorial or explanation on this point).

Let me ask you one more question.

I specify that I am, unfortunately, not with an ANSI US keyboard but an ISO keyboard Swiss_fr keyboard (Keychron Q6).

Here are my observations.

First test if I have in my "keymap.c" file these two lines (classic)

#include QMK_KEYBOARD_H
#include "keychron_common.h

If I put in a macro (in VIA) programmed on a free key of my keyboard :

Test Y
Test A
Test Z

The capital letters are well recorded and displayed if I run this command, the Y and Z are reversed because my keyboard is not US (which is normal) so to do it right I have to put a "Z" in place of a "Y" and vice versa.

This gives this in display:
Test Z
Test A
Test Y

Now if I have in my "keymap.c" file these lines

#include QMK_KEYBOARD_H
#include "keychron_common.h
#include "keymap_swiss_fr.h"
#include "sendstring_swiss_fr.h"

And in my macro in VIA

Test Y
Test A
Test Z

This will look like this:
test y
test a
test z

The "Y" and "Z" are right but I completely lose the characters in capital letters, everything is in lower case.

Would you have an explanation although you certainly don't have a keyboard other than ANSI and US, I don't know where else to ask my question (if I am not in the right section, my apologies)

Thank you for all your help and advice ;-) ... and my apologies for my bad English

@sigprof
Copy link
Contributor

sigprof commented Mar 13, 2023

This looks like a bug in quantum/keymap_extras/sendstring_swiss_fr.hthis area corresponds mostly to the capital letters in ASCII, so most of bits there should be 1, but they are 0 for some reason. Looks like it has been that way since #8689, where the translation table was added.

@AndroSteph
Copy link
Author

Thank you for your answer.

I don't know how to put a "BUG" tag in this topic, can you do it. Please and Thank you

@sigprof sigprof added the bug label Mar 13, 2023
@sigprof sigprof changed the title Strange behavior Capital letters not getting sent with sendstring_swiss_fr.h Mar 13, 2023
@AndroSteph
Copy link
Author

Thank you ! :-)

@AndroSteph
Copy link
Author

I can confirm that I have changed the lignes in the "sendstring_swiss_fr.h" fichier, and it is working better.

lignes :
36 - KCLUT_ENTRY(0, 1, 1, 1, 1, 1, 1, 1, 1),
37 - KCLUT_ENTRY(1, 1, 1, 1, 1, 1, 1, 1, 1),
38 - KCLUT_ENTRY(1, 1, 1, 1, 1, 1, 1, 1, 1),
39 - KCLUT_ENTRY(1, 1, 1, 0, 0, 0, 0, 1),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants