Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix capital letters not getting sent with sendstring_swiss_fr.h #20515

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Fix capital letters not getting sent with sendstring_swiss_fr.h #20515

merged 1 commit into from
Apr 20, 2023

Conversation

precondition
Copy link
Contributor

@precondition precondition commented Apr 20, 2023 •
edited by zvecr
Loading

Description

The ascii_to_shift_lut in sendstring_swiss_fr.h was missing 1 bits for each capital alphabet letter. Thus resulting in the bug where using send_string("ABCDE"); would send "abcde" in lowercase.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Apr 20, 2023
@zvecr zvecr requested a review from fauxpark April 20, 2023 11:42
@zvecr zvecr merged commit c3ae5c1 into qmk:develop Apr 20, 2023
@precondition precondition deleted the fix_sendstring_swiss_fr_capitals branch April 20, 2023 17:35
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@precondition @coquizen
Fix capital letters not getting sent with sendstring_swiss_fr.h (Issue …
eb52a66 
…qmk#20080) (qmk#20515)
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@precondition @autoferrit
Fix capital letters not getting sent with sendstring_swiss_fr.h (Issue …
57b61c1 
…qmk#20080) (qmk#20515)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@precondition @fauxpark @zvecr