Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V-USB: Fix initial dropped keypress #11263

Merged
merged 1 commit into from
Dec 22, 2020
Merged

V-USB: Fix initial dropped keypress #11263

merged 1 commit into from
Dec 22, 2020

Conversation

fauxpark
Copy link
Member

Description

The ordering of these function calls now match that of the LUFA code. Bootmagic Lite appears to still function, and the board sends the first key event again.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team December 21, 2020 05:57
Erovia
Erovia approved these changes Dec 22, 2020
View reviewed changes
Copy link
Member

@Erovia Erovia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't test it, but looks pretty harmless.

@Erovia Erovia requested a review from a team December 22, 2020 18:26
@fauxpark fauxpark merged commit 78b2f12 into qmk:master Dec 22, 2020
@fauxpark fauxpark deleted the vusb-init-fix branch December 22, 2020 20:33
nblyumberg pushed a commit to nblyumberg/qmk_firmware that referenced this pull request Dec 31, 2020
@fauxpark @nblyumberg
V-USB: Fix initial dropped keypress (qmk#11263)
d0e7993
xgnxs pushed a commit to xgnxs/qmk_firmware that referenced this pull request Jan 9, 2021
@fauxpark @xgnxs
V-USB: Fix initial dropped keypress (qmk#11263)
ba20ad0
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Jan 13, 2021
@fauxpark @drashna
V-USB: Fix initial dropped keypress (qmk#11263)
eaec0a1
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@fauxpark
V-USB: Fix initial dropped keypress (qmk#11263)
5856ea3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erovia Erovia Erovia approved these changes

Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] V-USB boards drop initial keypress
2 participants
@fauxpark @Erovia