Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unconditionally call led_init_ports #12116

Merged
merged 2 commits into from
Aug 3, 2021
Merged

Unconditionally call led_init_ports #12116

merged 2 commits into from
Aug 3, 2021

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Mar 5, 2021 •
edited
Loading

Description

Hopefully one of the last stages of the led refactor - resolve the following todo in quantum:

    // TODO: remove calls to led_init_ports from keyboards and remove ifdef

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added awaiting_pr Relies on another PR to be merged first in progress labels Mar 5, 2021
@zvecr zvecr removed awaiting_pr Relies on another PR to be merged first in progress labels Aug 2, 2021
@zvecr zvecr marked this pull request as ready for review August 2, 2021 22:28
@zvecr zvecr force-pushed the feature/tidy_led_init_ports branch from a5602fa to 668c9b4 Compare August 2, 2021 22:35
@zvecr zvecr force-pushed the feature/tidy_led_init_ports branch from 0149230 to e897258 Compare August 2, 2021 22:42
@zvecr zvecr requested a review from a team August 2, 2021 22:45
@zvecr zvecr added the breaking_change Changes that need to wait for a version increment label Aug 2, 2021
@zvecr zvecr merged commit 3f419dc into qmk:develop Aug 3, 2021
@daskygit daskygit mentioned this pull request Aug 3, 2021
Merged
9 tasks
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@zvecr @nhongooi
Unconditionally call led_init_ports (qmk#12116)
115c9ca 
* Unconditionally call led_init_ports

* Another call to led_init_ports
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@zvecr
Unconditionally call led_init_ports (qmk#12116)
ea327e1 
* Unconditionally call led_init_ports

* Another call to led_init_ports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
breaking_change Changes that need to wait for a version increment core keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @drashna @fauxpark