Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[develop] Fix knops keymaps #13872

Merged
merged 1 commit into from
Aug 4, 2021
Merged

[develop] Fix knops keymaps #13872

merged 1 commit into from
Aug 4, 2021

Conversation

daskygit
Copy link
Member

@daskygit daskygit commented Aug 3, 2021

Description

Noticed the knops/mini default keymap was broken in the webhook and then looking at #12116 there were some others.

Types of Changes

  • Bugfix
  • Keymap/layout/userspace (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the keymap label Aug 3, 2021
@zvecr zvecr requested a review from a team August 3, 2021 23:28
@daskygit daskygit mentioned this pull request Aug 4, 2021
Closed
9 tasks
@drashna drashna merged commit 3917fd5 into qmk:develop Aug 4, 2021
@daskygit daskygit deleted the fix/knops branch August 4, 2021 19:29
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@daskygit @nhongooi
[Keyboard] Fix knops keymaps (qmk#13872)
02fb4c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daskygit @drashna @zvecr