Add support for NO_PIN to all matrix types

[drashna]

Description

Adds support for NO_PIN in the regular matrices

Types of Changes

• Core
• Enhancement/optimization

Checklist

• My code follows the code style of this project: C, Python
• I have read the PR Checklist document and have made the appropriate changes.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[mtei]

I would say the better way is to define this function and use it.

static inline uint8_t readMatrixPin(pin_t pin) {
   if (pin != NO_PIN) {
       return readPin(pin);
   } else {
       return 1;
   }
}

[mtei]

I have one more suggestion.

-static void select_row(uint8_t row) { setPinOutput_writeLow(row_pins[row]); }
+static bool select_row(uint8_t row) {
+    pin_t pin = row_pins[row];
+    if (pin != NO_PIN) {
+        setPinOutput_writeLow(pin);
+        return true;
+    }
+    return false;
+}
 
-static void unselect_row(uint8_t row) { setPinInputHigh_atomic(row_pins[row]); }
+static void unselect_row(uint8_t row) {
+    pin_t pin = row_pins[row];
+    if (pin != NO_PIN) {
+        setPinInputHigh_atomic(pin);
+    }
+}
 
 static void unselect_rows(void) {
     for (uint8_t x = 0; x < MATRIX_ROWS; x++) {
-        if (row_pins[x] != NO_PIN) {
-            setPinInputHigh_atomic(row_pins[x]);
-        }
+        unselect_row(x);
     }
 }

@@ -113,8 +123,9 @@ static bool read_cols_on_row(matrix_row_t current_matrix[], uint8_t current_row)
     // Start with a clear matrix row
     matrix_row_t current_row_value = 0;
 
-    // Select row
-    select_row(current_row);
+    if (!select_row(current_row)) { // Select row
+        return false;  // skip NO_PIN row
+    }
     matrix_output_select_delay();

[stale]

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

[elfmimi]

I need to leave a note here. I'm guessing that the reason support for NO_PIN didn't exist until today is because QMK takes binary side into account very seriously. I've heard QMK is turning its wheel to the direction of data driven design. If so, check for NO_PIN could have been made to activated only for those do include NO_PINs in the definition. This was my thought on this PR.