Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Encoders mapped into the keymap array #12982

Closed
wants to merge 17 commits into from
Closed

Add support for Encoders mapped into the keymap array #12982

wants to merge 17 commits into from

Conversation

drashna
Copy link
Member

@drashna drashna commented May 22, 2021 •
edited
Loading

Description

This adds the ability to add positions in the LAYOUT for keyboards, to be able to use/set the encoder functionality. This is aimed at making encoders easier to support without custom code at the keyboard/keymap level.

To Do:

  • Add Documentation
  • Finalize naming conventions
  • Tweak setup?
  • Get working on both halves of split keyboard

Types of Changes

  • Core
  • Enhancement/optimization
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added CI cli qmk cli command core documentation keyboard keymap python translation via Adds via keymap and/or updates keyboard for via support labels May 22, 2021
@drashna drashna changed the base branch from master to develop May 22, 2021 18:50
@drashna drashna changed the title feature/encoder mapping Add support for Encoders mapped into the keymap array May 22, 2021
@drashna drashna requested a review from a team May 22, 2021 18:54
@github-actions github-actions bot removed via Adds via keymap and/or updates keyboard for via support CI keyboard keymap translation python documentation cli qmk cli command labels May 22, 2021
@drashna drashna mentioned this pull request May 22, 2021
Closed
14 tasks
@github-actions github-actions bot added keymap via Adds via keymap and/or updates keyboard for via support labels May 22, 2021
@drashna drashna force-pushed the feature/encoder_mapping branch 2 times, most recently from e6656e2 to e271cfb Compare May 22, 2021 19:15
@drashna drashna marked this pull request as draft May 23, 2021 04:55
@drashna drashna marked this pull request as ready for review June 1, 2021 20:55
@drashna drashna mentioned this pull request Jul 23, 2021
Closed
8 tasks
@tzarc tzarc added breaking_change Changes that need to wait for a version increment breaking_change_next labels Aug 17, 2021
@drashna drashna marked this pull request as draft October 7, 2021 01:20
@drashna
Copy link
Member Author

drashna commented Mar 13, 2022

Closed in favor of #13286

@drashna drashna closed this Mar 13, 2022
@drashna drashna deleted the feature/encoder_mapping branch March 13, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-8ch t-8ch t-8ch left review comments

Assignees
No one assigned
Labels
breaking_change Changes that need to wait for a version increment core documentation keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drashna @t-8ch @tzarc