Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 5 keyboards supported by the OverNumpad Controller #12688

Conversation

purdeaandrei
Copy link
Contributor

@purdeaandrei purdeaandrei commented Apr 25, 2021

Description

See here for details about the OverNumpad Controller: github

The following PRs are dependencies:

Also, this must go into develop, cause there are dependencies that are at the moment only merged into develop.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna added the awaiting_pr Relies on another PR to be merged first label May 13, 2021
@stale
Copy link

stale bot commented Jun 28, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@drashna drashna added the on hold label Jul 3, 2021
@stale stale bot removed the awaiting changes label Jul 3, 2021
@purdeaandrei purdeaandrei force-pushed the f_add_overnumpad_controller_keyboards branch 2 times, most recently from bde653c to b13b0f5 Compare August 26, 2021 22:59
@purdeaandrei purdeaandrei force-pushed the f_add_overnumpad_controller_keyboards branch from b13b0f5 to b06b5e2 Compare August 27, 2021 01:42
@purdeaandrei
Copy link
Contributor Author

I'm closing this PR and adding another one, to master, that doesn't have all the features. I'd rather get basic. non-feature-complete support for the controllers in, then have it held up by the pending dependencies, and since the support for the chip is now in master, there's no reason to hold up basic support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting_pr Relies on another PR to be merged first keyboard keymap on hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants