-
-
Notifications
You must be signed in to change notification settings - Fork 39.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F haptic disable when usb not configured or suspended #12692
F haptic disable when usb not configured or suspended #12692
Conversation
Note: the prerequisite PR is included here as the first commit. I may or may not need to do a force push once the prerequisite is merged, in order for github to not show the content of the prerequisite in the changes. |
Now also tested, and working as expected on atmega32u4, and atmega32u2, in addition to STM32F446. An interesting observation is that on atmega32u4 the solenoid clicks on a keypress that would bring the system out of suspend. This appears to be because of ordering of events, first USB comes out of the suspend state, and only after is the haptic feedback processed. |
Thank you for your contribution! |
c984838
to
347a621
Compare
Thank you for your contribution! |
347a621
to
40bfcfa
Compare
Rebased. |
f13e878
to
88b531a
Compare
Rebased on top of the latest power tracking PR, and tested again with an STM32F446-based keyboard |
88b531a
to
2116f5e
Compare
Rebased to fix conflict. Still awaiting other PR. |
2116f5e
to
d3b80d7
Compare
Not awaiting any other PR's anymore. |
If we can get the conflicts resolved, this should be good to go. |
…ended. This also add support for specifying a LED pin to indicate haptic status, and also adds support for a haptic-enable pin, which is useful to turn off the boost converter on the solenoid driver.
d3b80d7
to
51b2d2f
Compare
@tzarc Conflict fixed, just needed a rebase |
…ended. (qmk#12692) This also add support for specifying a LED pin to indicate haptic status, and also adds support for a haptic-enable pin, which is useful to turn off the boost converter on the solenoid driver.
Description
This also add support for specifying a LED pin to indicate haptic status,
and also adds support for a haptic-enable pin, which is useful to turn off
the boost converter on the solenoid driver.
This has been tested on chibios running on an STM32F446.
Also tested on atmega32u4, and also on atmega32u2.
The following pull-request was a pre-requisite: (it's now merged)
#12691Types of Changes
Issues Fixed or Closed by This PR
Checklist