Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add asym_eager_defer_pk debounce type #12689

Merged
merged 1 commit into from
Jun 16, 2021

Conversation

nomis
Copy link

@nomis nomis commented Apr 25, 2021

Description

Add asym_eager_defer_pk debounce type.

This branch is based on #12240 which has not yet been merged.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@KarlK90
Copy link
Member

KarlK90 commented Apr 27, 2021

I'm using it since you opened the PR and it works great. It also helped me finding a bug. I have the feeling that my tapped home-row modifiers are a tad more reliable now as they depend on clean key releases. Anyways looking forward to this being merged!

@tzarc tzarc requested a review from a team April 29, 2021 22:45
@drashna drashna added the awaiting_pr Relies on another PR to be merged first label Apr 30, 2021
@tzarc tzarc removed the awaiting_pr Relies on another PR to be merged first label Jun 9, 2021
@tzarc
Copy link
Member

tzarc commented Jun 9, 2021

Couple of conflicts now that #12240 was merged.

@nomis nomis force-pushed the debounce_asym_eager_defer_pk branch from 2a6f232 to 65f1272 Compare June 9, 2021 09:25
@nomis
Copy link
Author

nomis commented Jun 9, 2021

Couple of conflicts now that #12240 was merged.

I've rebased it; should be ok now.

@drashna drashna requested a review from a team June 16, 2021 03:58
@tzarc tzarc merged commit a0959f1 into qmk:develop Jun 16, 2021
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants