Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/bin/bash to /usr/bin/env bash #13422

Merged
merged 1 commit into from
Jul 6, 2021
Merged

/bin/bash to /usr/bin/env bash #13422

merged 1 commit into from
Jul 6, 2021

Conversation

kubatyszko
Copy link

@kubatyszko kubatyszko commented Jul 2, 2021 •
edited by zvecr
Loading

Changing path to bash from /bin/bash to more versatile /usr/bin/env bash

Description

Makes it more robust, especially on systems without bash under /bin/bash

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jul 2, 2021
@kubatyszko kubatyszko mentioned this pull request Jul 2, 2021
Closed
6 tasks
@drashna drashna requested a review from a team July 2, 2021 20:54
@fauxpark fauxpark requested a review from a team July 3, 2021 02:41
@skullydazed skullydazed merged commit acf7de7 into qmk:master Jul 6, 2021
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Jul 7, 2021
Merge remote-tracking branch 'qmk/develop' into develop
dd5a778 
* qmk/develop: (23 commits)
  Use the new ST7565 driver on Ergodox Infinity (qmk#13165)
  Xelus Ninjin: rename LAYOUT_all to LAYOUT_tkl_ansi_tsangan; add info.json (qmk#13477)
  Kopibeng XT65: Layout Macro Refactor (qmk#13476)
  [Keyboard] Add poker87c and poker87d (qmk#12810)
  [Keyboard] Add new Elise, 65% Keyboard ANSI / ISO  (qmk#12782)
  [Keyboard] Add bm65iso (qmk#13400)
  [Keyboard] Add keyboard reviung5 (qmk#13375)
  [Keyboard] Add kabedon98e (qmk#13314)
  [Keyboard] Set reasonable defaults for Corne keyboard (qmk#13440)
  /bin/bash to /usr/bin/env bash (qmk#13422)
  Update `MSG_PYTHON_MISSING` (qmk#13427)
  core: chibios: bootloader: use integer pointers as volatile (qmk#13450)
  Migrate SHIFT_ESC and RGB `fn_actions` to Grave Escape and RGB keycodes (qmk#13360)
  `keymap_extras`: Remove deprecated defines (qmk#12949)
  [Keyboard] fix encoder_update_user for nullbitsco/nibble (qmk#13451)
  Traveller cleanup (qmk#13441)
  LatinPadBLE: correct info.json data (qmk#13452)
  Jabberwocky: adjust key positioning in Configurator (qmk#13447)
  Molecule: Layout Macro Refactor (qmk#13453)
  [Docs] added list of MIDI keycodes (qmk#13159)
  ...
jakeprime pushed a commit to jakeprime/qmk_firmware that referenced this pull request Jul 10, 2021
@kubatyszko @jakeprime
/bin/bash to /usr/bin/env bash (qmk#13422)
ce7d75c
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
@kubatyszko @HokieGeek
/bin/bash to /usr/bin/env bash (qmk#13422)
5662353
wox pushed a commit to wox/qmk_firmware that referenced this pull request Aug 14, 2021
@kubatyszko @wox
/bin/bash to /usr/bin/env bash (qmk#13422)
ced2d4d
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@kubatyszko @nhongooi
/bin/bash to /usr/bin/env bash (qmk#13422)
25c48d8
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@kubatyszko
/bin/bash to /usr/bin/env bash (qmk#13422)
538867c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@skullydazed skullydazed skullydazed approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kubatyszko @fauxpark @skullydazed