core: chibios: bootloader: use integer pointers as volatile #13450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents gcc from incorrectly trying to validate array bounds.
```
tmk_core/common/chibios/bootloader.c: error: '__builtin_memcpy' offset [0, 21] is out of the bounds [0, 0] [-Werror=array-bounds]
107 | __builtin_memcpy((void *) VBAT, (const void *)sys_reset_to_loader_magic, sizeof(sys_reset_to_loader_magic));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99578#c16
Fixes qmk#12925
tzarc
reviewed
Jul 4, 2021
tzarc
approved these changes
Jul 4, 2021
fauxpark
approved these changes
Jul 5, 2021
|
Just thought you may want to check this works, as OP doesn't have a Kinetis device :) |
|
Ah, read up a bit on #12925. Without that context I was wildly confused... I haven't had any such issues compiling on my Debian system, though. Maybe we should ping @TheEdgeOfRage to check if it solves their issue? :) |
|
Whoops, didn't notice the linked issue. Sorry for the noise. |
|
No problem, happy to help anyway. 😛 |
|
I can confirm that the fix doesn't seem to introduce any issues on my Debian system at least. Compiling (still) works fine, and my |
cadusk
pushed a commit
to cadusk/qmk_firmware
that referenced
this pull request
Jul 7, 2021
* qmk/develop: (23 commits) Use the new ST7565 driver on Ergodox Infinity (qmk#13165) Xelus Ninjin: rename LAYOUT_all to LAYOUT_tkl_ansi_tsangan; add info.json (qmk#13477) Kopibeng XT65: Layout Macro Refactor (qmk#13476) [Keyboard] Add poker87c and poker87d (qmk#12810) [Keyboard] Add new Elise, 65% Keyboard ANSI / ISO (qmk#12782) [Keyboard] Add bm65iso (qmk#13400) [Keyboard] Add keyboard reviung5 (qmk#13375) [Keyboard] Add kabedon98e (qmk#13314) [Keyboard] Set reasonable defaults for Corne keyboard (qmk#13440) /bin/bash to /usr/bin/env bash (qmk#13422) Update `MSG_PYTHON_MISSING` (qmk#13427) core: chibios: bootloader: use integer pointers as volatile (qmk#13450) Migrate SHIFT_ESC and RGB `fn_actions` to Grave Escape and RGB keycodes (qmk#13360) `keymap_extras`: Remove deprecated defines (qmk#12949) [Keyboard] fix encoder_update_user for nullbitsco/nibble (qmk#13451) Traveller cleanup (qmk#13441) LatinPadBLE: correct info.json data (qmk#13452) Jabberwocky: adjust key positioning in Configurator (qmk#13447) Molecule: Layout Macro Refactor (qmk#13453) [Docs] added list of MIDI keycodes (qmk#13159) ...
|
For completeness sake, I can confirm that this fixed it for me. Thanks 👍 |
nhongooi
pushed a commit
to nhongooi/qmk_firmware
that referenced
this pull request
Dec 5, 2021
This prevents gcc from incorrectly trying to validate array bounds.
```
tmk_core/common/chibios/bootloader.c: error: '__builtin_memcpy' offset [0, 21] is out of the bounds [0, 0] [-Werror=array-bounds]
107 | __builtin_memcpy((void *) VBAT, (const void *)sys_reset_to_loader_magic, sizeof(sys_reset_to_loader_magic));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99578#c16
Fixes qmk#12925
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
This prevents gcc from incorrectly trying to validate array bounds.
```
tmk_core/common/chibios/bootloader.c: error: '__builtin_memcpy' offset [0, 21] is out of the bounds [0, 0] [-Werror=array-bounds]
107 | __builtin_memcpy((void *) VBAT, (const void *)sys_reset_to_loader_magic, sizeof(sys_reset_to_loader_magic));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99578#c16
Fixes qmk#12925
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
core: chibios: bootloader: use integer pointers as volatile
This prevents gcc from incorrectly trying to validate array bounds.
See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99578#c16
Types of Changes
Issues Fixed or Closed by This PR
Checklist
Note: This is only compile tested, as I don't have such a device.