Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Remove matrix_is_modified() and debounce_is_active() #15349

Merged
merged 2 commits into from
Nov 29, 2021
Merged

[Core] Remove matrix_is_modified() and debounce_is_active() #15349

merged 2 commits into from
Nov 29, 2021

Commits on Nov 29, 2021

  1. Remove matrix_is_modified() as it is dead code 

    This method was deprecated by commit b78c654
on 12th of march 2013 which should be enough time by now. It also served
no real purpose and was not used by any code in QMK.
    @KarlK90
    KarlK90 committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    24c57c1 View commit details
    Browse the repository at this point in the history

  2. Remove debounce_active() as it is dead code 

    this method was used in matrix_is_modified() to determine if a matrix had
changes, but was never correctly implemented for all algorithms yet used
in practice. With the removal of matrix_is_modified() there is no reason to
keep it.
    @KarlK90
    KarlK90 committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    769e59b View commit details
    Browse the repository at this point in the history