Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Remove matrix_is_modified() and debounce_is_active() #15349

Merged
merged 2 commits into from
Nov 29, 2021
Merged

[Core] Remove matrix_is_modified() and debounce_is_active() #15349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24c57c1
Remove matrix_is_modified() as it is dead code
KarlK90 Nov 29, 2021
769e59b
Remove debounce_active() as it is dead code
KarlK90 Nov 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions keyboards/40percentclub/ut47/matrix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,12 +104,6 @@ uint8_t matrix_scan(void)
return 1;
}

bool matrix_is_modified(void)
{
if (debouncing) return false;
return true;
}

inline
bool matrix_is_on(uint8_t row, uint8_t col)
{
Expand Down
5 changes: 0 additions & 5 deletions keyboards/ai03/orbit/matrix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,11 +83,6 @@ inline uint8_t matrix_rows(void) { return MATRIX_ROWS; }

inline uint8_t matrix_cols(void) { return MATRIX_COLS; }

bool matrix_is_modified(void) {
if (debounce_active()) return false;
return true;
}

inline bool matrix_is_on(uint8_t row, uint8_t col) { return (matrix[row] & ((matrix_row_t)1 << col)); }

inline matrix_row_t matrix_get_row(uint8_t row) { return matrix[row]; }
Expand Down
6 changes: 0 additions & 6 deletions keyboards/amj96/matrix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,12 +108,6 @@ uint8_t matrix_scan(void)
return 1;
}

bool matrix_is_modified(void)
{
if (debouncing) return false;
return true;
}

inline
bool matrix_is_on(uint8_t row, uint8_t col)
{
Expand Down
7 changes: 0 additions & 7 deletions keyboards/angel64/alpha/matrix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,13 +90,6 @@ uint8_t matrix_cols(void) {
return MATRIX_COLS;
}

//Deprecated.
bool matrix_is_modified(void)
{
if (debounce_active()) return false;
return true;
}

inline
bool matrix_is_on(uint8_t row, uint8_t col)
{
Expand Down
7 changes: 0 additions & 7 deletions keyboards/angel64/rev1/matrix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,13 +90,6 @@ uint8_t matrix_cols(void) {
return MATRIX_COLS;
}

//Deprecated.
bool matrix_is_modified(void)
{
if (debounce_active()) return false;
return true;
}

inline
bool matrix_is_on(uint8_t row, uint8_t col)
{
Expand Down
7 changes: 0 additions & 7 deletions keyboards/bpiphany/kitten_paw/matrix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,13 +117,6 @@ uint8_t matrix_scan(void) {
return 1;
}

bool matrix_is_modified(void) {
if (debouncing)
return false;
else
return true;
}

inline bool matrix_is_on(uint8_t row, uint8_t col) {
return (matrix[row] & ((matrix_row_t)1<<col));
}
Expand Down
7 changes: 0 additions & 7 deletions keyboards/bpiphany/pegasushoof/2013/matrix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,13 +110,6 @@ uint8_t matrix_scan(void)
return 1;
}

bool matrix_is_modified(void)
{
if (debouncing)
return false;
return true;
}

inline
bool matrix_is_on(uint8_t row, uint8_t col)
{
Expand Down
7 changes: 0 additions & 7 deletions keyboards/converter/palm_usb/matrix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,6 @@ static uint16_t disconnect_counter = 0;
#define COL(code) ((code & COL_MASK) )
#define KEYUP(code) ((code & KEY_MASK) >>7 )

static bool is_modified = false;

__attribute__ ((weak))
void matrix_init_kb(void) {
matrix_init_user();
Expand Down Expand Up @@ -354,11 +352,6 @@ uint8_t matrix_scan(void)
return code;
}

bool matrix_is_modified(void)
{
return is_modified;
}

inline
bool matrix_has_ghost(void)
{
Expand Down
7 changes: 0 additions & 7 deletions keyboards/converter/sun_usb/matrix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,6 @@ static uint8_t matrix[MATRIX_ROWS];
#define ROW(code) ((code>>3)&0xF)
#define COL(code) (code&0x07)

static bool is_modified = false;

__attribute__ ((weak))
void matrix_init_kb(void) {
matrix_init_user();
Expand Down Expand Up @@ -154,11 +152,6 @@ uint8_t matrix_scan(void)
return code;
}

bool matrix_is_modified(void)
{
return is_modified;
}

inline
bool matrix_has_ghost(void)
{
Expand Down
4 changes: 0 additions & 4 deletions keyboards/converter/usb_usb/custom_matrix.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,10 +192,6 @@ extern "C"
return 1;
}

bool matrix_is_modified(void) {
return matrix_is_mod;
}

bool matrix_is_on(uint8_t row, uint8_t col) {
uint8_t code = CODE(row, col);

Expand Down
8 changes: 0 additions & 8 deletions keyboards/dc01/arrow/matrix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,14 +205,6 @@ uint8_t matrix_scan(void)
return 1;
}

bool matrix_is_modified(void)
{
#if (DEBOUNCE > 0)
if (debouncing) return false;
#endif
return true;
}

inline
bool matrix_is_on(uint8_t row, uint8_t col)
{
Expand Down
8 changes: 0 additions & 8 deletions keyboards/dc01/left/matrix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,14 +230,6 @@ if (i2c_transaction(SLAVE_I2C_ADDRESS_NUMPAD, 0x1FFFF, 11)) {
return 1;
}

bool matrix_is_modified(void)
{
#if (DEBOUNCE > 0)
if (debouncing) return false;
#endif
return true;
}

inline
bool matrix_is_on(uint8_t row, uint8_t col)
{
Expand Down
8 changes: 0 additions & 8 deletions keyboards/dc01/numpad/matrix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,14 +205,6 @@ uint8_t matrix_scan(void)
return 1;
}

bool matrix_is_modified(void)
{
#if (DEBOUNCE > 0)
if (debouncing) return false;
#endif
return true;
}

inline
bool matrix_is_on(uint8_t row, uint8_t col)
{
Expand Down
8 changes: 0 additions & 8 deletions keyboards/dc01/right/matrix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,14 +206,6 @@ uint8_t matrix_scan(void)
return 1;
}

bool matrix_is_modified(void)
{
#if (DEBOUNCE > 0)
if (debouncing) return false;
#endif
return true;
}

inline
bool matrix_is_on(uint8_t row, uint8_t col)
{
Expand Down
6 changes: 0 additions & 6 deletions keyboards/dm9records/ergoinu/matrix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,12 +223,6 @@ void matrix_slave_scan(void) {
}
}

bool matrix_is_modified(void)
{
if (debouncing) return false;
return true;
}

inline
bool matrix_is_on(uint8_t row, uint8_t col)
{
Expand Down
6 changes: 0 additions & 6 deletions keyboards/duck/jetfire/matrix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,12 +116,6 @@ uint8_t matrix_scan(void)
return 1;
}

bool matrix_is_modified(void)
{
if (debouncing) return false;
return true;
}

inline
bool matrix_is_on(uint8_t row, uint8_t col)
{
Expand Down
4 changes: 0 additions & 4 deletions keyboards/ergodox_stm32/matrix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,10 +119,6 @@ uint8_t matrix_scan(void) {
return 0;
}

bool matrix_is_modified(void) {
return true;
}

inline
bool matrix_is_on(uint8_t row, uint8_t col) {
return (matrix[row] & (1 << col));
Expand Down
5 changes: 0 additions & 5 deletions keyboards/ergotaco/matrix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,11 +199,6 @@ uint8_t matrix_scan(void)
return 1;
}

bool matrix_is_modified(void) // deprecated and evidently not called.
{
return true;
}

inline
bool matrix_is_on(uint8_t row, uint8_t col)
{
Expand Down
5 changes: 0 additions & 5 deletions keyboards/gboards/gergoplex/matrix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,11 +152,6 @@ uint8_t matrix_scan(void) {
return 1;
}

bool matrix_is_modified(void) // deprecated and evidently not called.
{
return true;
}

inline bool matrix_is_on(uint8_t row, uint8_t col) { return (matrix[row] & ((matrix_row_t)1 << col)); }
inline matrix_row_t matrix_get_row(uint8_t row) { return matrix[row]; }

Expand Down
5 changes: 0 additions & 5 deletions keyboards/georgi/matrix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,11 +220,6 @@ uint8_t matrix_scan(void)
return 1;
}

bool matrix_is_modified(void) // deprecated and evidently not called.
{
return true;
}

inline
bool matrix_is_on(uint8_t row, uint8_t col)
{
Expand Down
5 changes: 0 additions & 5 deletions keyboards/gergo/matrix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,11 +273,6 @@ uint8_t matrix_scan(void) {
return 1;
}

bool matrix_is_modified(void) // deprecated and evidently not called.
{
return true;
}

inline bool matrix_is_on(uint8_t row, uint8_t col) { return (matrix[row] & ((matrix_row_t)1 << col)); }

inline matrix_row_t matrix_get_row(uint8_t row) { return matrix[row]; }
Expand Down
8 changes: 0 additions & 8 deletions keyboards/handwired/dactyl/matrix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,14 +281,6 @@ uint8_t matrix_scan(void)
return 1;
}

bool matrix_is_modified(void) // deprecated and evidently not called.
{
#if (DEBOUNCE > 0)
if (debouncing) return false;
#endif
return true;
}

inline
bool matrix_is_on(uint8_t row, uint8_t col)
{
Expand Down
6 changes: 0 additions & 6 deletions keyboards/handwired/frenchdev/matrix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,12 +174,6 @@ uint8_t matrix_scan(void)
return 1;
}

bool matrix_is_modified(void)
{
if (debouncing) return false;
return true;
}

inline
bool matrix_is_on(uint8_t row, uint8_t col)
{
Expand Down
6 changes: 0 additions & 6 deletions keyboards/handwired/not_so_minidox/matrix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,12 +239,6 @@ void matrix_slave_scan(void) {
#endif
}

bool matrix_is_modified(void)
{
if (debouncing) return false;
return true;
}

inline
bool matrix_is_on(uint8_t row, uint8_t col)
{
Expand Down
8 changes: 0 additions & 8 deletions keyboards/handwired/promethium/matrix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,14 +148,6 @@ uint8_t matrix_scan(void)
return 1;
}

bool matrix_is_modified(void)
{
#if (DEBOUNCE > 0)
if (debouncing) return false;
#endif
return true;
}

inline
bool matrix_is_on(uint8_t row, uint8_t col)

Expand Down
8 changes: 0 additions & 8 deletions keyboards/handwired/pterodactyl/matrix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,14 +282,6 @@ uint8_t matrix_scan(void)
return 1;
}

bool matrix_is_modified(void) // deprecated and evidently not called.
{
#if (DEBOUNCE > 0)
if (debouncing) return false;
#endif
return true;
}

inline
bool matrix_is_on(uint8_t row, uint8_t col)
{
Expand Down
6 changes: 0 additions & 6 deletions keyboards/helix/pico/matrix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,12 +273,6 @@ void matrix_slave_scan(void) {
#endif
}

bool matrix_is_modified(void)
{
if (debouncing) return false;
return true;
}

inline
bool matrix_is_on(uint8_t row, uint8_t col)
{
Expand Down
6 changes: 0 additions & 6 deletions keyboards/helix/rev1/matrix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,12 +239,6 @@ void matrix_slave_scan(void) {
#endif
}

bool matrix_is_modified(void)
{
if (debouncing) return false;
return true;
}

inline
bool matrix_is_on(uint8_t row, uint8_t col)
{
Expand Down
Loading