Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for bootloader refactor build failures #15638

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

fauxpark
Copy link
Member

Description

#15450 broke compilation for some boards, and exposed a couple of problems with others.

  • Moved STM32_BOOTLOADER_ADDRESS declarations to mcu_selection.mk; deleted all bootloader_defs.h and removed any instances of it as a define
  • Removed reference to enter_bootloader_mode_if_requested() for matrix/abelx
  • Set correct bootloader for mechmini/v1
  • Set bootloader for mode/m65s
  • Removed some logic in CLI that was causing the bootloader selection to default to stm32-dfu
  • Added missing include for GD32 bootloader implementation

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc merged commit 5fb9393 into qmk:develop Jan 5, 2022
@fauxpark fauxpark deleted the bootloader-refactor-fixes branch January 6, 2022 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants