Fix broken bootloader builds in develop. #15880
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Most are just missing a bootloader assignment as the change to info.py in #15638 seems to now require the bootloader to be set specifically in info.json.
This also adds a weak
enter_bootloader_mode_if_requested
so chibios builds with an unknown bootloader will compile successfully with an accompanying pragma message.These keychron boards require the
BOOTLOADER
setting andSTM32_BOOTLOADER_ADDRESS
defining (which would go against the previous work if added to rules.mk). Maybe the MCU configuration should be added tobuilddefs/mcu_selection.mk
in a separate PR. (Compiles as a unknown bootloader with this PR)These 2 matrix boards using custom booloaders now also compiles with the unknown bootloader pragma message.
Types of Changes
Issues Fixed or Closed by This PR
Checklist