-
-
Notifications
You must be signed in to change notification settings - Fork 40.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Re-order user space rules inclusion #17459
Conversation
cdb0c24
to
1cfaf59
Compare
I'm not sure how I feel about allowing userspace to override the MCU. It very much feels the opposite of what is supposed to happen (specific to general, keyboard -> keymap -> userspace). |
keyboard/keymap/rules.mk can overwrite MCU selection but not the copy in userspace. I had the impression that "overwrite" priority is In its current position, |
This seems to have broken some compiles (I noticed it with when using It seems to have changed ordering of community layout's An an aside, the docs at https://docs.qmk.fm/#/hardware_keyboard_guidelines?id=rulesmk need to be updated (for this change, and also to explain when community layout This could be somewhat fixed by allowing |
This reverts commit 69fa2d8.
Description
Re-order inclusion of userspace
rules.mk
beforemcu_selection.mk
to support overriding micro controller settings, such as chibiosCONVERT_TO
converters orMCU
selection.Confirmed binary reproducibility with
planck/rev6
andcrkbd/rev1
.Types of Changes
Checklist