Revert "[Core] Re-order user space rules inclusion (#17459)" #18032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 69fa2d8.
tzarc
approved these changes
Aug 13, 2022
nolanseaton
pushed a commit
to nolanseaton/qmk_firmware
that referenced
this pull request
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 69fa2d8.
Description
PR #17459 has broken some community layouts that depend on userspace code, because it loads userspace
rules.mkbefore community layoutrules.mk, thereby removing the ability to turn settings on/off in the community layout, and then react to those settings in the build of the userspace code. For example, seelayouts/community/75_ansi/spidey3.This PR rolls back #17459 for now.
Types of Changes
Issues Fixed or Closed by This PR
[see above]
Checklist