Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to avoid deprecated wmic execution #18122

Merged
merged 3 commits into from
Oct 31, 2022
Merged

Refactor to avoid deprecated wmic execution #18122

merged 3 commits into from
Oct 31, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Aug 20, 2022 •
edited
Loading

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Aug 20, 2022
@zvecr zvecr changed the title wmic deprecated? Refactor to avoid deprecated wmic execution Oct 21, 2022
@zvecr zvecr marked this pull request as ready for review October 21, 2022 22:42
@zvecr zvecr requested a review from a team October 21, 2022 22:42
fauxpark
fauxpark reviewed Oct 22, 2022
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Select -ExpandProperty "DeviceID" might help here?

$ powershell.exe 'Get-CimInstance -Class Win32_SerialPort | Select -ExpandProperty "DeviceID"'
COM1
COM3

zvecr
zvecr commented Oct 29, 2022
View reviewed changes
platforms/avr/flash.mk Outdated Show resolved Hide resolved
zvecr
zvecr commented Oct 29, 2022
View reviewed changes
platforms/avr/flash.mk Outdated Show resolved Hide resolved
@zvecr zvecr requested review from fauxpark and a team October 29, 2022 22:59
@zvecr zvecr merged commit 96c48a5 into master Oct 31, 2022
@fauxpark fauxpark deleted the zvecr-patch-2 branch October 31, 2022 20:35
aivalja pushed a commit to aivalja/qmk_firmware that referenced this pull request Nov 7, 2022
@zvecr
Refactor to avoid deprecated wmic execution (qmk#18122)
5800aa2 
* wmic deprecated?

* Update platforms/avr/flash.mk

* Update platforms/avr/flash.mk
wezzynl added a commit to wezzynl/qmk_firmware that referenced this pull request Nov 8, 2022
@wezzynl
Merge branch 'master' into dev
6358305 
* master: (5478 commits)
  [Keyboard] Add Brutal v2 1800 PCB to QMK (qmk#18891)
  [Keyboard] Refactor chinese PCB folder (qmk#18923)
  [Keyboard] Add ISO Encoder variant of Keychron Q1v1 (qmk#18829)
  [Keymap] Add model01 and doio/kb16 keymaps (qmk#18681)
  [Keymap] KO Kyria (qmk#18413)
  [Keyboard] Add Work Louder Numpad (qmk#18912)
  [Keyboard]  Add hotdox76v2 support (qmk#18680)
  Refactor to avoid deprecated wmic execution (qmk#18122)
  Phoebe: Add key to print screen (qmk#18856)
  Star75 Refactor (qmk#18885)
  [Keyboard] Add Hubble keyboard (qmk#18718)
  Remove duplicate key in novelkeys/nk65b (qmk#18907)
  [Keyboard] Update Kay65 LED state (qmk#18895)
  Add indicator LEDs to hoodrow G PCB (qmk#18888)
  [Keymap] toshi0383 keymaps update (qmk#18760)
  [Keyboard] Add Encoder map support for rart (qmk#18851)
  [Keyboard] Add Sinc Rev 1&2 Encoder Map Support (qmk#18861)
  Docs: fix a typo (qmk#18896)
  MelGeek MJ6XY Refactor (qmk#18862)
  [Keyboard] Minor Aurora Sweep fixes (qmk#18879)
  ...
thystips pushed a commit to thystips/qmk_firmware that referenced this pull request Nov 24, 2022
@zvecr @thystips
Refactor to avoid deprecated wmic execution (qmk#18122)
5340c16 
* wmic deprecated?

* Update platforms/avr/flash.mk

* Update platforms/avr/flash.mk
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@zvecr @ramonimbao
Refactor to avoid deprecated wmic execution (qmk#18122)
d907017 
* wmic deprecated?

* Update platforms/avr/flash.mk

* Update platforms/avr/flash.mk
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
@zvecr @elpekenin
Refactor to avoid deprecated wmic execution (qmk#18122)
1278ad1 
* wmic deprecated?

* Update platforms/avr/flash.mk

* Update platforms/avr/flash.mk
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@zvecr @nolanseaton
Refactor to avoid deprecated wmic execution (qmk#18122)
f9881e7 
* wmic deprecated?

* Update platforms/avr/flash.mk

* Update platforms/avr/flash.mk
ChrisChrisLoLo pushed a commit to ChrisChrisLoLo/qmk_firmware that referenced this pull request Sep 2, 2023
@zvecr @ChrisChrisLoLo
Refactor to avoid deprecated wmic execution (qmk#18122)
ad98da1 
* wmic deprecated?

* Update platforms/avr/flash.mk

* Update platforms/avr/flash.mk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @drashna @fauxpark