Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[keyboard] Add Phantagom numpads #18493
[keyboard] Add Phantagom numpads #18493
Changes from 13 commits
a6e8dd2
9708839
e74cfe5
219b2b1
9f4e4db
353923f
b8c025f
bf78313
fc78835
4fb53dc
e601a61
6b954a9
98e295c
126d7b8
a46e62b
406c959
b40080c
e9df87b
aabfdea
5de4a9d
836d38d
2e05067
9acc8ab
4980717
89d0681
9c154e2
181d7f7
6827099
1bba49f
805ea91
74920ab
b04b2f1
3956101
6ddb020
93bc065
94092a0
477eb40
a4e8ad0
8710c16
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get_u8_str
andget_u16_str
will do this, and without using itoa, which can be expensive, size wise.if neither of these work, then you could simply use
get_numeric_str
instead.All of these are in quantum.c, and available anywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know what you mean, but not how to solve it, not a C programmer :( but learning a lot ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you only wanted 2 digits:
and
oled_write_2digits(uptime, '0')
would print out what you want.I'm not sure of the compile size difference compared with itoa, but may be worth testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This way I am getting extra leading 0, that I don't want, it's a uptime clock.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oled_write_2digits(uptime, ' ')
would fix that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could all of this be moved to
oled_mpad.c
, and use theoled_task_kb
function?