[keyboard] Add Phantagom numpads #18493

dkruyt · 2022-09-26T20:41:14Z

Description

Add support for 2 numpads / marco pads. Includes default and via support.

Types of Changes

Issues Fixed or Closed by This PR

Checklist

My code follows the code style of this project: C, Python
I have read the PR Checklist document and have made the appropriate changes.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/phantagom/oled_mpad/config.h

keyboards/phantagom/oled_mpad/keymaps/default/keymap.c

keyboards/phantagom/oled_mpad/oled_mpad.h

keyboards/phantagom/rgb_npad/keymaps/default/keymap.c

keyboards/phantagom/rgb_npad/keymaps/via/keymap.c

keyboards/phantagom/rgb_npad/rgb_npad.c

keyboards/phantagom/rgb_npad/rgb_npad.h

Co-authored-by: Drashna Jaelre <drashna@live.com>

…nt work

keyboards/phantagom/oled_mpad/keymaps/via/keymap.c

keyboards/phantagom/oled_mpad/config.h

Co-authored-by: Nick Brassel <nick@tzarc.org>

* bastardkb: cleanup blackpill configuration Fixes qmk#17 * bastardkb: fix splinky configuration The pinout of the splinky changed between the last beta batch, and the production one. This commit updates the keyboard definition to support the new pinout by default, while offering backward compatibility. Define `SPLINKY_BETA_PINOUT` to build the firmware with pre-production pinout. Fixes qmk#15 * bastardkb: add support for STeMCell * Update scylla/tbkmini/skeletyl outdated readmes * bastardkb/dilemma: enable circular scroll * bastardkb/dilemma: add initial version of the `via` keymap * bastardkb/dilemma/assembled: add new keyboard Fixes qmk#20 * bastardkb/dilemma: remove elite-c * Initial support for the Dilemma 3x5+3 Assembled RGB * Address code review comments * Address more comments * Address review comments * Address more nits * bastardkb: split splinky-based keyboards to distinguish between Splinky v2 and v3 pinout

)

Co-authored-by: Ryan <fauxpark@gmail.com>

Swap Hands on/off - it's `SH_ON/OFF` not `SW_ON/OFF`

ANAVI Knob 1 is a mini mechanical keyboard with a clickable rotary encoder, USB-C, RP2040 microcontroller and I2C slot for a display. Signed-off-by: Leon Anavi <leon.anavi@konsulko.com> Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>

* Furthark layout

* Latest updates * Aligning and cleaning up planck and babyv layouts * Added license, cleaned up errors

keyboards/phantagom/rgb_npad/readme.md

keyboards/phantagom/rgb_npad/info.json

Co-authored-by: Drashna Jaelre <drashna@live.com>

github-actions · 2023-01-05T02:02:37Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

drashna · 2023-01-12T08:35:42Z

keyboards/phantagom/oled_mpad/keymaps/default/keymap.c

+}
+
+#ifdef OLED_ENABLE
+bool oled_task_user(void) {


could all of this be moved to oled_mpad.c, and use the oled_task_kb function?

waffle87 · 2023-01-13T02:56:39Z

keyboards/phantagom/oled_mpad/info.json

+    "name": "oled_mpad",
+    "keyboard_name": "oled_mpad",
+    "manufacturer": "Phantagom",
+    "vendorId": "0xF8E8",
+    "productId": "0x0001",
+    "matrix": { "rows": 6, "cols": 5 },
+    "url": "",
+    "lighting": "qmk_rgblight",


Suggested change

"name": "oled_mpad",

"keyboard_name": "oled_mpad",

"manufacturer": "Phantagom",

"vendorId": "0xF8E8",

"productId": "0x0001",

"matrix": { "rows": 6, "cols": 5 },

"url": "",

"lighting": "qmk_rgblight",

"keyboard_name": "oled_mpad",

"manufacturer": "Phantagom",

waffle87 · 2023-01-13T02:58:06Z

keyboards/phantagom/oled_mpad/keymaps/default/keymap.c

+void matrix_init_user(void) {
+  // set CapsLock LED to output and low
+  setPinOutput(GP4);
+  writePinLow(GP4);
+  // set NumLock LED to output and low
+  setPinOutput(GP5);
+  writePinLow(GP5);
+  // set ScrollLock LED to output and low
+  setPinOutput(GP6);
+  writePinLow(GP6);
+}
+
+void led_update_ports(led_t led_state) {
+    writePin(GP4, led_state.num_lock);
+    writePin(GP5, led_state.caps_lock);
+    writePin(GP6, led_state.scroll_lock);
+}


Suggested change

void matrix_init_user(void) {

// set CapsLock LED to output and low

setPinOutput(GP4);

writePinLow(GP4);

// set NumLock LED to output and low

setPinOutput(GP5);

writePinLow(GP5);

// set ScrollLock LED to output and low

setPinOutput(GP6);

writePinLow(GP6);

}

void led_update_ports(led_t led_state) {

writePin(GP4, led_state.num_lock);

writePin(GP5, led_state.caps_lock);

writePin(GP6, led_state.scroll_lock);

}

waffle87 · 2023-01-13T03:00:03Z

keyboards/phantagom/oled_mpad/info.json

+        "vid": "0xF8E8",
+        "pid": "0x0001",
+        "device_version": "0.0.3"
+    },


Suggested change

},

},

"indicators": {

"caps_lock": "GP5",

"num_lock": "GP4",

"scroll_lock": "GP6",

"on_state": 0

},

waffle87 · 2023-01-13T03:01:13Z

keyboards/phantagom/oled_mpad/keymaps/via/keymap.c

+void matrix_init_user(void) {
+  // set CapsLock LED to output and low
+  setPinOutput(GP4);
+  writePinLow(GP4);
+  // set NumLock LED to output and low
+  setPinOutput(GP5);
+  writePinLow(GP5);
+  // set ScrollLock LED to output and low
+  setPinOutput(GP6);
+  writePinLow(GP6);
+}
+
+bool led_update_kb(led_t led_state) {
+    bool res = led_update_user(led_state);
+    if(res) {
+        writePin(GP4, led_state.num_lock);
+        writePin(GP5, led_state.caps_lock);
+        //writePin(B2, led_state.scroll_lock);
+    }
+    return res;
+}


Suggested change

void matrix_init_user(void) {

// set CapsLock LED to output and low

setPinOutput(GP4);

writePinLow(GP4);

// set NumLock LED to output and low

setPinOutput(GP5);

writePinLow(GP5);

// set ScrollLock LED to output and low

setPinOutput(GP6);

writePinLow(GP6);

}

bool led_update_kb(led_t led_state) {

bool res = led_update_user(led_state);

if(res) {

writePin(GP4, led_state.num_lock);

writePin(GP5, led_state.caps_lock);

//writePin(B2, led_state.scroll_lock);

}

return res;

}

waffle87 · 2023-01-13T03:01:56Z

keyboards/phantagom/oled_mpad/readme.md

@@ -0,0 +1,8 @@
+# OLED_MPAD
+
+![OLED_MPAD](https://i.imgur.com/EEJFeOl.jpeg)


Suggested change

![OLED_MPAD](https://i.imgur.com/EEJFeOl.jpeg)

![OLED_MPAD](https://i.imgur.com/EEJFeOlh.jpeg)

waffle87 · 2023-01-13T03:04:58Z

keyboards/phantagom/rgb_npad/readme.md

@@ -0,0 +1,8 @@
+# RGB_NPAD
+
+![RGB_NPAD](https://i.imgur.com/EuGAMye.jpeg)


Suggested change

![RGB_NPAD](https://i.imgur.com/EuGAMye.jpeg)

![RGB_NPAD](https://i.imgur.com/EuGAMyeh.jpeg)

waffle87 · 2023-01-13T03:05:15Z

keyboards/phantagom/rgb_npad/rules.mk

+# MCU name
+MCU = RP2040
+# Bootloader selection
+BOOTLOADER = rp2040


Suggested change

# MCU name

MCU = RP2040

# Bootloader selection

BOOTLOADER = rp2040

waffle87 · 2023-01-13T03:05:44Z

keyboards/phantagom/rgb_npad/info.json

+    "keyboard_name": "rgb_npad",
+    "manufacturer": "Phantagom",
+    "url": "",
+    "maintainer": "Phantagom",


Suggested change

"maintainer": "Phantagom",

"maintainer": "Phantagom",

"processor": "RP2040",

"bootloader": "rp2040",

waffle87 · 2023-01-13T03:07:04Z

keyboards/phantagom/rgb_npad/rules.mk

+NKRO_ENABLE = yes           # Enable N-Key Rollover
+BACKLIGHT_ENABLE = no       # Enable keyboard backlight functionality
+RGBLIGHT_ENABLE = yes        # Enable keyboard RGB underglow
+RGBLIGHT_DRIVER = WS2812


Suggested change

RGBLIGHT_DRIVER = WS2812

waffle87 · 2023-01-13T03:07:22Z

keyboards/phantagom/rgb_npad/mcuconf.h

@@ -0,0 +1,19 @@
+/*


This file should be removed.

github-actions · 2023-02-28T02:04:47Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions · 2023-03-31T01:57:08Z

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]

dkruyt added 2 commits September 26, 2022 22:33

initial commit for phantagom numpads

a6e8dd2

Merge branch 'qmk:master' into phantagom-pads

9708839

github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Sep 26, 2022

dkruyt added 2 commits September 26, 2022 22:55

remove keymap from json

e74cfe5

linting fixes

219b2b1

drashna requested changes Sep 27, 2022

View reviewed changes

dkruyt and others added 9 commits September 27, 2022 08:08

Update keyboards/phantagom/oled_mpad/config.h

9f4e4db

Co-authored-by: Drashna Jaelre <drashna@live.com>

Update keyboards/phantagom/oled_mpad/keymaps/default/keymap.c

353923f

Co-authored-by: Drashna Jaelre <drashna@live.com>

Update keyboards/phantagom/oled_mpad/keymaps/default/keymap.c

b8c025f

Co-authored-by: Drashna Jaelre <drashna@live.com>

Update keyboards/phantagom/oled_mpad/keymaps/default/keymap.c

bf78313

Co-authored-by: Drashna Jaelre <drashna@live.com>

Update keyboards/phantagom/oled_mpad/keymaps/default/keymap.c

fc78835

Co-authored-by: Drashna Jaelre <drashna@live.com>

cleanup rules

4fb53dc

license

e601a61

remove device info

6b954a9

fixes for get_u16_str and revert to update_kb, user compiles but does…

98e295c

…nt work

joukewitteveen reviewed Oct 10, 2022

View reviewed changes

keyboards/phantagom/oled_mpad/keymaps/via/keymap.c Show resolved Hide resolved

drashna reviewed Oct 14, 2022

View reviewed changes

keyboards/phantagom/oled_mpad/config.h Outdated Show resolved Hide resolved

dkruyt added 4 commits October 26, 2022 21:48

Merge branch 'qmk:master' into phantagom-pads

126d7b8

led_update_kb -> led_update_user

a46e62b

remove default address

406c959

changed to led_update_ports and enabled scroll lock

b40080c

dkruyt requested a review from drashna October 26, 2022 20:43

dkruyt and others added 6 commits November 13, 2022 10:07

Merge branch 'qmk:master' into phantagom-pads

e9df87b

fix: mousekey doesn't work with trackpoint (qmk#18474)

aabfdea

Co-authored-by: Nick Brassel <nick@tzarc.org>

Cleanup. (qmk#19061)

5de4a9d

Fixup day_off (qmk#19067)

836d38d

[Keyboard] change BT LEDs so no longer hard coded in Anne Pro (qmk#18934

9acc8ab

)

Xelus22 and others added 9 commits November 18, 2022 10:00

[Keyboard] Add Constellation Rev3 (qmk#18868)

4980717

Co-authored-by: Ryan <fauxpark@gmail.com>

Fix typo (qmk#19035)

89d0681

Swap Hands on/off - it's `SH_ON/OFF` not `SW_ON/OFF`

keyboards/anavi: Add ANAVI Knob 1 (qmk#18623)

9c154e2

ANAVI Knob 1 is a mini mechanical keyboard with a clickable rotary encoder, USB-C, RP2040 microcontroller and I2C slot for a display. Signed-off-by: Leon Anavi <leon.anavi@konsulko.com> Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>

Planck unicode rune layout (qmk#18674)

181d7f7

* Furthark layout

Personal keymap updates (qmk#18763)

6827099

* Latest updates * Aligning and cleaning up planck and babyv layouts * Added license, cleaned up errors

[Docs] Note default value for TAP_CODE_DELAY (qmk#19078)

1bba49f

Specify DEFAULT_FOLDER for v2/splinky (qmk#19093)

805ea91

Use keyboard_pre_init_kb(void) at keyboard level (qmk#19091)

74920ab

Disable onekey console by default (qmk#19104)

b04b2f1

github-actions bot added core documentation labels Nov 18, 2022

Merge branch 'qmk:master' into phantagom-pads

3956101

github-actions bot removed core documentation labels Nov 18, 2022

drashna requested changes Nov 20, 2022

View reviewed changes

dkruyt and others added 6 commits November 20, 2022 09:14

Update keyboards/phantagom/rgb_npad/info.json

6ddb020

Co-authored-by: Drashna Jaelre <drashna@live.com>

Update keyboards/phantagom/rgb_npad/info.json

93bc065

Co-authored-by: Drashna Jaelre <drashna@live.com>

Update keyboards/phantagom/rgb_npad/info.json

94092a0

Co-authored-by: Drashna Jaelre <drashna@live.com>

rehosted on imgur

477eb40

rehosted on imgur

a4e8ad0

Merge branch 'qmk:master' into phantagom-pads

8710c16

github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jan 5, 2023

drashna reviewed Jan 12, 2023

View reviewed changes

github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Jan 13, 2023

waffle87 requested changes Jan 13, 2023

View reviewed changes

github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Feb 28, 2023

github-actions bot closed this Mar 31, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[keyboard] Add Phantagom numpads #18493

[keyboard] Add Phantagom numpads #18493

dkruyt commented Sep 26, 2022

github-actions bot commented Jan 5, 2023

drashna Jan 12, 2023

waffle87 Jan 13, 2023

waffle87 Jan 13, 2023

waffle87 Jan 13, 2023

waffle87 Jan 13, 2023

waffle87 Jan 13, 2023

waffle87 Jan 13, 2023

waffle87 Jan 13, 2023

waffle87 Jan 13, 2023

waffle87 Jan 13, 2023

waffle87 Jan 13, 2023

github-actions bot commented Feb 28, 2023

github-actions bot commented Mar 31, 2023

-    },
+    },
+    "indicators": {
+        "caps_lock": "GP5",
+        "num_lock": "GP4",
+        "scroll_lock": "GP6",
+        "on_state": 0
+    },

		@@ -0,0 +1,8 @@
		# OLED_MPAD

		![OLED_MPAD](https://i.imgur.com/EEJFeOl.jpeg)

		@@ -0,0 +1,8 @@
		# RGB_NPAD

		![RGB_NPAD](https://i.imgur.com/EuGAMye.jpeg)

	![RGB_NPAD](https://i.imgur.com/EuGAMye.jpeg)
	![RGB_NPAD](https://i.imgur.com/EuGAMyeh.jpeg)

[keyboard] Add Phantagom numpads #18493

[keyboard] Add Phantagom numpads #18493

Conversation

dkruyt commented Sep 26, 2022

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

github-actions bot commented Jan 5, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Feb 28, 2023

github-actions bot commented Mar 31, 2023