Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CLI community detection #19562

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jan 11, 2023

Description

Short term fix with some lazy imports to avoid circular includes. Fixing this more correctly will require significant code reshuffles. Ignoring whitespace somewhat helps due to some indentation changes.

Fixes issues:

  • only checking LAYOUTS in rule.mk and not also community_layouts in info.json
  • only checking layouts/community and not also layouts/default

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team January 11, 2023 00:52
@github-actions github-actions bot added cli qmk cli command python labels Jan 11, 2023
@zvecr zvecr added the bug label Jan 11, 2023
@tzarc tzarc merged commit 20474ae into qmk:develop Jan 11, 2023
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cli qmk cli command python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants