Fix MATRIX_HAS_GHOST when MATRIX_COL > 16 #20093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When MATRIX_COL > 16 get_real_keys() does not work correctly because the 1 << col overflows, since matrix_row_t is uint32_t. This causes keypresses to be lost on keyboards with more than 16 columns.
drashna
reviewed
Mar 14, 2023
|
Also, since this really is a bugfix, it could probably target master. |
|
Got it. OK, do you want me to close this and open a new one targeting master? |
If you edit the title, it will let you retarget. Though, it may be tricky with extra commits. For now, can just leave it. See what others say. |
|
@drashna I retargeted it to master. Thoughts on merging it now? |
drashna
approved these changes
Apr 4, 2023
tzarc
approved these changes
Apr 30, 2023
struckmb
pushed a commit
to struckmb/qmk_firmware
that referenced
this pull request
May 1, 2023
rodrigob
pushed a commit
to rodrigob/qmk_firmware
that referenced
this pull request
May 2, 2023
barrettclark
added a commit
to barrettclark/qmk_firmware
that referenced
this pull request
May 4, 2023
* upstream/master: (46 commits) [Keyboard] Add 1upkeyboards pi50 (qmk#20242) `sofle/via` encoder map & doc handedness update (qmk#20630) [Keyboard] add phantagom/baragon marcopad (qmk#20543) [Keyboard] add phantagom/varan rgb numpad (qmk#20587) [Keymap] Small changes to fix failing karn keyboard build (qmk#20618) Repair Spleeb i2c config and chrishoage keymap (qmk#20644) Adding my keymap (qmk#20345) Add additional options for Drag Scroll config (qmk#20523) Added Velvet Hotswap and Solder PCBs (qmk#20510) [Keyboard] Add the Aster Ergo PCB (qmk#20513) vertex/angle65 - Implement RGBlight (qmk#20514) [Keymap update] Keymap & docs update (qmk#20298) Fix MATRIX_HAS_GHOST when MATRIX_COL > 16 (qmk#20093) ez_maker/directpins/promicro: Fix bootloader mismatch (qmk#20627) Fix up positioning of keys for Keychron Q10/V10 and Q6/V6 (qmk#20582) [Keymap] Add johnstegeman iris colemak keymap (qmk#20575) [Keyboard] Add Manibus VIA support (qmk#20497) Add KBDCraft Adam64 Lego board (qmk#20503) Update code example to match description (qmk#20528) NK Plus (qmk#20392) ...
autoferrit
pushed a commit
to SpaceRockMedia/bastardkb-qmk
that referenced
this pull request
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When MATRIX_COL > 16 get_real_keys() does not work correctly because the
1 << colshift overflows, since matrix_row_t is uint32_t. This causes key presses to be lost on keyboards with more than 16 columns.Types of Changes
Checklist