Adding my keymap #20345

jestes5111 · 2023-04-05T12:43:01Z

Description

Adding my Iris keymap, focused on editing in VIM/Excel, gaming, and keyboard-focused media consumption.

Types of Changes

Issues Fixed or Closed by This PR

N/A

Checklist

My code follows the code style of this project: C, Python
I have read the PR Checklist document and have made the appropriate changes.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/keebio/iris/keymaps/jestes5111/config.h

keyboards/keebio/iris/keymaps/jestes5111/keymap.c

keyboards/keebio/iris/keymaps/jestes5111/rules.mk

lib/chibios

drashna

It looks like you have changes to the submodules here. These need to be reverted before the PR can be approved.

Rebasing sometimes will fix this. Otherwise, you'd want to do something like this to fix them:

git checkout master
git submodule foreach 'git log -n1 --oneline'
# remember the first abcdef1234 on the submodules that have an issue
git checkout @@your-branch@@
# for each of the problematic repo's:
cd lib/@@name@@
git checkout abcdef1234

keyboards/keebio/iris/keymaps/jestes5111/README.md

keyboards/keebio/iris/keymaps/jestes5111/keymap.svg

keyboards/keebio/iris/keymaps/jestes5111/keymap.c

…o get everything that was missing/incorrect

jestes5111

Updated as per requests

keyboards/keebio/iris/keymaps/jestes5111/keymap.c

elpekenin · 2023-04-10T11:51:34Z

Note: #20345 (comment)

jestes5111

Made requested changes

jestes5111

Updated as per requests

keyboards/keebio/iris/keymaps/jestes5111/README.md

jestes5111

Made requested changes

waffle87 · 2023-04-19T05:17:42Z

Two reviewers have requested you rename your README.md file to lowercase. Please do not mark comments as resolved without making the changes...

jestes5111

readme.md should actually be lowercase now. I renamed it locally when I was initially requested to change it to lowercase, but it never updated here.

jestes5111

Reviewing older changes

drashna · 2023-04-27T03:50:37Z

keyboards/keebio/iris/keymaps/jestes5111/keymap.c

+                SEND_STRING(":disguised_face: :thumbsup:");
+                wait_ms(100);
+                tap_code(KC_ENTER);


Suggested change

SEND_STRING(":disguised_face: :thumbsup:");

wait_ms(100);

tap_code(KC_ENTER);

SEND_STRING(":disguised_face: :thumbsup:" SS_DELAY(100) SS_TAP(X_ENTER));

* upstream/master: (46 commits) [Keyboard] Add 1upkeyboards pi50 (qmk#20242) `sofle/via` encoder map & doc handedness update (qmk#20630) [Keyboard] add phantagom/baragon marcopad (qmk#20543) [Keyboard] add phantagom/varan rgb numpad (qmk#20587) [Keymap] Small changes to fix failing karn keyboard build (qmk#20618) Repair Spleeb i2c config and chrishoage keymap (qmk#20644) Adding my keymap (qmk#20345) Add additional options for Drag Scroll config (qmk#20523) Added Velvet Hotswap and Solder PCBs (qmk#20510) [Keyboard] Add the Aster Ergo PCB (qmk#20513) vertex/angle65 - Implement RGBlight (qmk#20514) [Keymap update] Keymap & docs update (qmk#20298) Fix MATRIX_HAS_GHOST when MATRIX_COL > 16 (qmk#20093) ez_maker/directpins/promicro: Fix bootloader mismatch (qmk#20627) Fix up positioning of keys for Keychron Q10/V10 and Q6/V6 (qmk#20582) [Keymap] Add johnstegeman iris colemak keymap (qmk#20575) [Keyboard] Add Manibus VIA support (qmk#20497) Add KBDCraft Adam64 Lego board (qmk#20503) Update code example to match description (qmk#20528) NK Plus (qmk#20392) ...

jestes5111 added 16 commits April 22, 2022 10:45

Adding my keymap

ae126cb

Merge branch 'qmk:master' into master

4729003

Changed RESET to QK_RBT

58aee1c

Changed QK_RBT to QK_BOOT

9ce3351

Moved mouse keys to be vim keys, removed numpad keys

a928443

Moved fill password to RCS(L) (default BW bind)

5c00f38

Updated submodules

ab9d216

RCS(L) -> RCS(KC_L), added QMK CLI flash shortcut

a5a11b5

FLASH macro -> QK_MAKE

1415253

Restructured nearly everything. Needs more work

9860732

Updated formatting

c6b5fed

Refactored to match the newest default keymap. LEDs update by layer

c073aa5

More layer changing. Hoping to get it closer to 'finalized'

8ebae38

Added a README and a keymap picture

1752f2d

Added a README and a keymap picture

c32381c

Updated README.md and copyrights in config.h

0442291

github-actions bot added dependencies keymap labels Apr 5, 2023

elpekenin suggested changes Apr 5, 2023

View reviewed changes

drashna requested changes Apr 5, 2023

View reviewed changes

keyboards/keebio/iris/keymaps/jestes5111/README.md Outdated Show resolved Hide resolved

keyboards/keebio/iris/keymaps/jestes5111/keymap.svg Outdated Show resolved Hide resolved

keyboards/keebio/iris/keymaps/jestes5111/keymap.c Outdated Show resolved Hide resolved

jestes5111 added 4 commits April 7, 2023 09:10

Merge remote-tracking branch 'upstream/master'

8fe1da6

Updated personal code to match requests in PR. Merged with upstream t…

1c874eb

…o get everything that was missing/incorrect

Merge branch 'qmk:master' into master

77842da

Removed duplicates from rules.mk

765e346

jestes5111 commented Apr 7, 2023

View reviewed changes

elpekenin suggested changes Apr 7, 2023

View reviewed changes

keyboards/keebio/iris/keymaps/jestes5111/keymap.c Outdated Show resolved Hide resolved

keyboards/keebio/iris/keymaps/jestes5111/keymap.c Outdated Show resolved Hide resolved

keyboards/keebio/iris/keymaps/jestes5111/keymap.c Outdated Show resolved Hide resolved

Further improvements from PR suggestions

5dbe472

jestes5111 requested a review from drashna April 10, 2023 11:49

jestes5111 commented Apr 11, 2023

View reviewed changes

jestes5111 added 3 commits April 13, 2023 08:02

Merge branch 'qmk:master' into master

6ccfef0

Merge branch 'qmk:master' into master

4cae119

Fixed image in readme

533e6cd

waffle87 reviewed Apr 17, 2023

View reviewed changes

keyboards/keebio/iris/keymaps/jestes5111/README.md Outdated Show resolved Hide resolved

Fixing readme.md as per suggestions

34c0d8b

jestes5111 commented Apr 18, 2023

View reviewed changes

Lowercase readme

a734842

jestes5111 commented Apr 19, 2023

View reviewed changes

Merge branch 'qmk:master' into master

75938ed

waffle87 approved these changes Apr 23, 2023

View reviewed changes

jestes5111 commented Apr 25, 2023

View reviewed changes

drashna reviewed Apr 27, 2023

View reviewed changes

drashna approved these changes Apr 27, 2023

View reviewed changes

tzarc approved these changes Apr 30, 2023

View reviewed changes

tzarc merged commit c55c7fe into qmk:master Apr 30, 2023

struckmb pushed a commit to struckmb/qmk_firmware that referenced this pull request May 1, 2023

Adding my keymap (qmk#20345)

d5a0e3d

rodrigob pushed a commit to rodrigob/qmk_firmware that referenced this pull request May 2, 2023

Adding my keymap (qmk#20345)

68a06f6

autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023

Adding my keymap (qmk#20345)

d0c0fd4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding my keymap #20345

Adding my keymap #20345

jestes5111 commented Apr 5, 2023

drashna left a comment

jestes5111 left a comment

elpekenin commented Apr 10, 2023

jestes5111 left a comment

jestes5111 left a comment

jestes5111 left a comment

waffle87 commented Apr 19, 2023 •

edited

Loading

jestes5111 left a comment

jestes5111 left a comment

drashna Apr 27, 2023

Adding my keymap #20345

Adding my keymap #20345

Conversation

jestes5111 commented Apr 5, 2023

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

drashna left a comment

Choose a reason for hiding this comment

jestes5111 left a comment

Choose a reason for hiding this comment

elpekenin commented Apr 10, 2023

jestes5111 left a comment

Choose a reason for hiding this comment

jestes5111 left a comment

Choose a reason for hiding this comment

jestes5111 left a comment

Choose a reason for hiding this comment

waffle87 commented Apr 19, 2023 • edited Loading

jestes5111 left a comment

Choose a reason for hiding this comment

jestes5111 left a comment

Choose a reason for hiding this comment

drashna Apr 27, 2023

Choose a reason for hiding this comment

waffle87 commented Apr 19, 2023 •

edited

Loading