-
-
Notifications
You must be signed in to change notification settings - Fork 39.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add QuadrumLabs Delta #20409
Add QuadrumLabs Delta #20409
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keyboards/quadrum/delta/keymaps/default/rules.mk
should be added with just ENCODER_MAP_ENABLE = yes
Submodule changes must also be reverted before this PR can be accepted.
e5d4b58
to
ce40c78
Compare
How can I remove the lib stuff from it? Every time I commit it seems to include it for whatever reason |
git checkout develop
make git-submodule
git submodule foreach 'git log -n1 --oneline'
# remember the first abcdef1234 on the submodules that have an issue
git checkout @@your-branch@@
# for each of the problematic repo's:
cd lib/@@name@@
git checkout abcdef1234
cd @@qmk_firmware@@
git commit -m 'Resync submodules' |
Fixed, thanks @waffle87! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Layouts need some work — apparently what you have here is LAYOUT_all
(unbuildable as it is, because ANSI backslash is separate from ISO NUHS on this PCB, therefore you need to use 1.25u Enter to make all matrix positions assignable), but a lone LAYOUT_all
is not allowed by the rules, so you would need to add at least LAYOUT_ansi
and LAYOUT_iso
with appropriate modifications. (Maybe you should also provide layout variations for 2u Backspace, but you would need to check which matrix location corresponds to the 2u position.)
Co-authored-by: Joel Challis <git@zvecr.com>
* master: NK Plus (qmk#20392) [Docs] Fix suggested code pattern when a specific mod-mask is required. (qmk#20512) [Docs] Remove combo count from array (qmk#20511) Add QuadrumLabs Delta (qmk#20409) Adds Docs option for ArduinoIDE's example `ArduinoISP` (qmk#20486) GMMK 2 volume up/down Fn keys are backwards in default mapping (qmk#20476) Fix typo in `feature_wpm.md` title (qmk#20464) [Keyboard] Add Kalakos Bahrnob65 (qmk#20424) Tidy up stray RGB_DISABLE_TIMEOUT references (qmk#20460) [Keyboard] Add zoom75 wired (qmk#20396) [Keyboard] Add dymium65 (qmk#20257) Lotus58 glow (qmk#20386) ADPenrose Obi Layout Macro Conversion and Addition (qmk#20445)
This replaces #18198 because lfg went AWOL
I had to remake this from the gerbers and it was awful
Description
Adds QuadrumLabs Delta to QMK
Types of Changes
Issues Fixed or Closed by This PR
Checklist