[Docs] Fix suggested code pattern when a specific mod-mask is required. #20512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Namely, remove the suggested use of AND (&)
drashna
approved these changes
Apr 20, 2023
waffle87
approved these changes
Apr 21, 2023
|
This marks my hundredth closed pull request on GitHub! |
queyenth
pushed a commit
to queyenth/qmk_firmware
that referenced
this pull request
Apr 21, 2023
14 tasks
stratosgear
pushed a commit
to stratosgear/qmk_firmware
that referenced
this pull request
Apr 26, 2023
struckmb
pushed a commit
to struckmb/qmk_firmware
that referenced
this pull request
May 1, 2023
rodrigob
pushed a commit
to rodrigob/qmk_firmware
that referenced
this pull request
May 2, 2023
SjB
added a commit
to SjB/qmk_firmware
that referenced
this pull request
May 12, 2023
* master: NK Plus (qmk#20392) [Docs] Fix suggested code pattern when a specific mod-mask is required. (qmk#20512) [Docs] Remove combo count from array (qmk#20511) Add QuadrumLabs Delta (qmk#20409) Adds Docs option for ArduinoIDE's example `ArduinoISP` (qmk#20486) GMMK 2 volume up/down Fn keys are backwards in default mapping (qmk#20476) Fix typo in `feature_wpm.md` title (qmk#20464) [Keyboard] Add Kalakos Bahrnob65 (qmk#20424) Tidy up stray RGB_DISABLE_TIMEOUT references (qmk#20460) [Keyboard] Add zoom75 wired (qmk#20396) [Keyboard] Add dymium65 (qmk#20257) Lotus58 glow (qmk#20386) ADPenrose Obi Layout Macro Conversion and Addition (qmk#20445)
autoferrit
pushed a commit
to SpaceRockMedia/bastardkb-qmk
that referenced
this pull request
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The suggested way to check if
get_mods()matches only a certain set of mod bits was wrong.Types of Changes
Issues Fixed or Closed by This PR
Checklist