Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip parsing g_led_config when matrix_size is missing #23941

Closed
wants to merge 2 commits into from

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jun 17, 2024

Description

From the recent core CI runs, qmk find -km all currently falls over due to recent changes, where matrix_size is no longer present in .json.

Also added qmk --verbose find handling so that diagnosing issues is somewhat easier.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added python cli qmk cli command labels Jun 17, 2024
@zvecr zvecr added the bug label Jun 17, 2024
@fauxpark
Copy link
Member

This should never need to be skipped because matrix_size should always be present internally, either derived from the row/col/direct pins arrays, or parsed from config.h for custom matrix. This issue is a symptom of a failure earlier on which happens to cause matrix_size not to be assigned.

@fauxpark
Copy link
Member

fauxpark commented Jun 17, 2024

It appears all of the boards causing this error are the ones which are completely failing schema validation, ie. these ones:

Ψ Retrieving list of all keyboards and keymaps...
Oh no darkproject/kd87a_bfg_edition
Oh no doio/kb38
Oh no handwired/alcor_dactyl
Oh no kbdfans/kbdpad/mk3
Oh no meletrix/zoom98
Oh no projectd/65/projectd_65_ansi
Oh no projectd/75/ansi
Oh no projectd/75/iso
Oh no rot13labs/h4ckb0ard
Oh no skeletonkbd/frost68
Oh no theone

The same command run on that branch succeeds. Not sure why the EC980C and BAMFK4 do not show up here though.

@zvecr zvecr closed this Jun 30, 2024
@zvecr zvecr deleted the matrix_size_search branch June 30, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cli qmk cli command python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants