-
-
Notifications
You must be signed in to change notification settings - Fork 40.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip parsing g_led_config when matrix_size is missing #24739
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzarc
approved these changes
Dec 27, 2024
haxwagon
pushed a commit
to haxwagon/qmk_firmware
that referenced
this pull request
Jan 3, 2025
LeonMusCoden
pushed a commit
to LeonMusCoden/qmk_firmware
that referenced
this pull request
Jan 5, 2025
ichichou
pushed a commit
to ichichou/qmk_firmware
that referenced
this pull request
Jan 8, 2025
le4ker
pushed a commit
to le4ker/lily58-firmware
that referenced
this pull request
Jan 8, 2025
MichaelScofield45
pushed a commit
to MichaelScofield45/qmk_firmware
that referenced
this pull request
Jan 8, 2025
milosbugarinovic
pushed a commit
to milosbugarinovic/qmk_firmware
that referenced
this pull request
Jan 13, 2025
pashashocky
pushed a commit
to pashashocky/qmk
that referenced
this pull request
Jan 17, 2025
vinniefranco
pushed a commit
to Good-Great-Grand-Wonderful/qmk_firmware
that referenced
this pull request
Jan 20, 2025
fsecilia
pushed a commit
to fsecilia/qmk_firmware
that referenced
this pull request
Jan 27, 2025
Rumadon
pushed a commit
to Rumadon/qmk_firmware
that referenced
this pull request
Jan 31, 2025
MaximumP
pushed a commit
to MaximumP/qmk_firmware
that referenced
this pull request
Feb 1, 2025
alinelena
pushed a commit
to alinelena/qmk_firmware
that referenced
this pull request
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resurrecting #23941.
While its true this error should generally not happen to valid keyboards, users are constantly tripped up by the python stack trace that is otherwise spat out. This stack trace is output even if the board is not attempting to support RGB/LED matrix.
This wall of text leads them down paths that are irrelevant to their issue. Worse is when reaching out for help, they then post the stack trace (usually as a screenshot...), and not the full output that shows the actual error that triggered
matrix_size
to be undefined.Before:
After:
Types of Changes
Issues Fixed or Closed by This PR
Checklist