Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review fixes for layer lock feature #24627

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Review fixes for layer lock feature #24627

merged 1 commit into from
Nov 21, 2024

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Nov 21, 2024 •
edited
Loading

Description

Looks like i didnt actually hit the "submit review" button on #23430.

  • Avoid LAYER_LOCK_IDLE_TIMEOUT implementation bleeding out
  • Fix compilation with NO_ACTION_LAYER
  • Remove incorrect comment content

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Nov 21, 2024
@zvecr zvecr added bug core and removed core labels Nov 21, 2024
@zvecr zvecr merged commit 968a611 into qmk:develop Nov 21, 2024
4 checks passed
@zvecr zvecr deleted the layer_lock_review branch November 21, 2024 13:02
ilham-agustiawan pushed a commit to ilham-agustiawan/qmk_firmware that referenced this pull request Nov 30, 2024
@zvecr @ilham-agustiawan
Review fixes for layer lock feature (qmk#24627)
235856a
smallketchup82 pushed a commit to smallketchup82/qmk_firmware that referenced this pull request Dec 1, 2024
@zvecr @smallketchup82
Review fixes for layer lock feature (qmk#24627)
b863b29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @tzarc