Fix Ergodox KEYMAP macros #3052
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noroadsleft
added a commit
to noroadsleft/qmk_firmware
that referenced
this pull request
May 25, 2018
|
Travis CI errors are unrelated |
drashna
pushed a commit
that referenced
this pull request
May 25, 2018
mechmerlin
reviewed
May 28, 2018
| @@ -151,7 +149,7 @@ inline void ergodox_led_all_set(uint8_t n) { | |||
| { B80, B81, B82, B83, B84 } \ | |||
| } | |||
|
|
|||
| #define LAYOUT_ergodox KEYMAP | |||
| #define LAYOUT_ergodox_pretty KEYMAP_PRETTY | |||
| #define KEYMAP LAYOUT_ergodox | |||
There was a problem hiding this comment.
Why do we need to #define KEYMAP to this?
There was a problem hiding this comment.
We don't, this was a "quick and dirty" change, and I didn't want to change all of the keymaps.
carlpehrson
pushed a commit
to carlpehrson/qmk_firmware
that referenced
this pull request
May 30, 2018
drashna
force-pushed
the
ergo_fix
branch
2 times, most recently
from
81e522b to
9fd2f1c
Compare
|
Fixed in #3171 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To use the LAYOUT convention by default, and then map KEYMAP to that for compatibility.
I think @skullydazed mentioned some fix to the Configurator that may fix this. But just in case.... here is this PR