Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added custom keymap for preonic #7548

Merged
merged 3 commits into from
Feb 21, 2020
Merged

Added custom keymap for preonic #7548

merged 3 commits into from
Feb 21, 2020

Conversation

elisiano
Copy link
Contributor

@elisiano elisiano commented Dec 5, 2019

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

fauxpark
fauxpark requested changes Dec 5, 2019
View reviewed changes
keyboards/preonic/keymaps/elisiano/keymap.c Outdated Show resolved Hide resolved
keyboards/preonic/keymaps/elisiano/keymap.c Outdated Show resolved Hide resolved
keyboards/preonic/keymaps/elisiano/keymap.c Outdated Show resolved Hide resolved
keyboards/preonic/keymaps/elisiano/keymap.c Outdated Show resolved Hide resolved
keyboards/preonic/keymaps/elisiano/keymap.c Outdated Show resolved Hide resolved
keyboards/preonic/keymaps/elisiano/keymap.c Outdated Show resolved Hide resolved
keyboards/preonic/keymaps/elisiano/keymap.c Outdated Show resolved Hide resolved
keyboards/preonic/keymaps/elisiano/keymap.c Outdated Show resolved Hide resolved
@fauxpark fauxpark added the keymap label Dec 5, 2019
@fauxpark fauxpark requested a review from a team December 5, 2019 12:07
drashna
drashna reviewed Dec 8, 2019
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from what fauxpark has mentioned, it looks good!

If you need any help with applying changes, let us know.

@elisiano elisiano force-pushed the preonic/keymap/elisiano branch 2 times, most recently from 2d83cca to 84bb3b9 Compare January 16, 2020 14:56
@elisiano
Copy link
Contributor Author

Apologies for the delay, this notification went buried in my mailbox.
I think I've addressed the comments, please let me know if there's anything else.
(I did flash the firmware and I'm typing with it right now 👍).

The reason why there were "extra" thing in this PR is because I was trying to keep my file in sync with master/default and apply only my changes. I guess it's not necessary 😀

fauxpark
fauxpark approved these changes Jan 16, 2020
View reviewed changes
keyboards/preonic/keymaps/elisiano/keymap.c Outdated Show resolved Hide resolved
@elisiano @fauxpark
Update keyboards/preonic/keymaps/elisiano/keymap.c
704a4bb 
Co-Authored-By: fauxpark <fauxpark@gmail.com>
@fauxpark fauxpark requested a review from a team January 18, 2020 01:40
ridingqwerty
ridingqwerty approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@ridingqwerty ridingqwerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM provided @elisiano isn't bothered by the MOUSE default layer setter pointed out by drashna.

@ridingqwerty
Copy link
Contributor

Thanks @elisiano , I think we're good here!

@ridingqwerty ridingqwerty merged commit a4af41c into qmk:master Feb 21, 2020
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request Feb 23, 2020
@elisiano @fauxpark @sowbug
Added custom keymap for preonic (qmk#7548)
c4d4c56 
* Added custom keymap

* Update keyboards/preonic/keymaps/elisiano/keymap.c

Co-Authored-By: fauxpark <fauxpark@gmail.com>

* Address PR comments and added CTL_T(KC_ESC) on other layouts as well

Co-authored-by: Ryan <fauxpark@gmail.com>
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Feb 25, 2020
@Shinichi-Ohki
Merge branch 'master' of https://github.com/qmk/qmk_firmware
034c505 
* 'master' of https://github.com/qmk/qmk_firmware: (108 commits)
  `send_unicode_string()`: Add support for code points > 0xFFFF (qmk#8236)
  [Keyboard] Add Wete (qmk#8229)
  Improvements to extrakey HID descriptors (qmk#8156)
  Hineybush h87a lock indicators (qmk#8237)
  Add VIA support for Prime_L (qmk#8233)
  Hub16 - Bug removal + clean up code (qmk#8227)
  [Keyboard] ai03 Equinox (qmk#8224)
  [Keyboard] Add zfrontier/big_switch (qmk#8205)
  Gingham Update (qmk#8225)
  A proper `send_string()` for the Unicode feature (qmk#8155)
  Rollback PR qmk#7967 in preference of fixing I2C start/stop properly, in a followup PR. (qmk#8173)
  Add mouse support to SEND_STRING (qmk#8223)
  Add link to "Useful functions" in macro docs (qmk#7446)
  New functionality for cformat (qmk#7893)
  Update main.c (qmk#8198)
  format code according to conventions [skip ci]
  Fix QWIIC OLED for AVR (qmk#7769)
  VIA Support: KBD75 rev1/rev2 (qmk#8214)
  Update TMOv2 for new key (qmk#7759)
  Added custom keymap for preonic (qmk#7548)
  ...
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Mar 5, 2020
@elisiano @fauxpark @HokieGeek
Added custom keymap for preonic (qmk#7548)
015a184 
* Added custom keymap

* Update keyboards/preonic/keymaps/elisiano/keymap.c

Co-Authored-By: fauxpark <fauxpark@gmail.com>

* Address PR comments and added CTL_T(KC_ESC) on other layouts as well

Co-authored-by: Ryan <fauxpark@gmail.com>
c0psrul3 pushed a commit to c0psrul3/qmk_firmware that referenced this pull request Mar 23, 2020
@elisiano @fauxpark @c0psrul3
Added custom keymap for preonic (qmk#7548)
8f03645 
* Added custom keymap

* Update keyboards/preonic/keymaps/elisiano/keymap.c

Co-Authored-By: fauxpark <fauxpark@gmail.com>

* Address PR comments and added CTL_T(KC_ESC) on other layouts as well

Co-authored-by: Ryan <fauxpark@gmail.com>
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@elisiano @fauxpark @kujawakk
Added custom keymap for preonic (qmk#7548)
f00d5a5 
* Added custom keymap

* Update keyboards/preonic/keymaps/elisiano/keymap.c

Co-Authored-By: fauxpark <fauxpark@gmail.com>

* Address PR comments and added CTL_T(KC_ESC) on other layouts as well

Co-authored-by: Ryan <fauxpark@gmail.com>
jakeisnt pushed a commit to jakeisnt/qmk_firmware that referenced this pull request Aug 20, 2020
@elisiano @fauxpark @jakeisnt
Added custom keymap for preonic (qmk#7548)
4a853c4 
* Added custom keymap

* Update keyboards/preonic/keymaps/elisiano/keymap.c

Co-Authored-By: fauxpark <fauxpark@gmail.com>

* Address PR comments and added CTL_T(KC_ESC) on other layouts as well

Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna left review comments

@ridingqwerty ridingqwerty ridingqwerty approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elisiano @ridingqwerty @drashna @fauxpark