Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New flags and functionality for cformat #7893

Merged
merged 1 commit into from
Feb 23, 2020
Merged

New flags and functionality for cformat #7893

merged 1 commit into from
Feb 23, 2020

Conversation

Curry
Copy link
Contributor

@Curry Curry commented Jan 14, 2020 •
edited
Loading

Description

qmk cformat <file1> <file2> <...> <fileN> functionality remains unchanged
qmk cformat -a formats all core files, same as old qmk cformat behavior
qmk cformat now only formats files that have changed between local and default origin/master. Branch can be changed via the -b flag.

Types of Changes

  • Core
  • Enhancement/optimization

Issues Fixed or Closed by This PR

Dependencies

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@skullydazed skullydazed added cli qmk cli command python labels Jan 14, 2020
@skullydazed skullydazed requested a review from a team January 14, 2020 05:31
Erovia
Erovia requested changes Jan 14, 2020
View reviewed changes
Copy link
Member

@Erovia Erovia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR and impressive reaction time to #7884. :)
We are generally moving from os.path to pathlib (#7872), so most of my suggestions are based on this.

lib/python/qmk/tests/test_cli_commands.py Outdated Show resolved Hide resolved
lib/python/qmk/cli/cformat.py Outdated Show resolved Hide resolved
lib/python/qmk/cli/cformat.py Show resolved Hide resolved
lib/python/qmk/cli/cformat.py Outdated Show resolved Hide resolved
lib/python/qmk/cli/cformat.py Outdated Show resolved Hide resolved
lib/python/qmk/cli/cformat.py Outdated Show resolved Hide resolved
lib/python/qmk/cli/cformat.py Outdated Show resolved Hide resolved
@Erovia
Copy link
Member

Erovia commented Feb 8, 2020

@Curry when you have a minute, please check the conversation I've unresolved.

@Curry Curry force-pushed the 7884_cformat branch 5 times, most recently from 58bd2a3 to e4f255d Compare February 16, 2020 16:53
Curry
Curry commented Feb 16, 2020
View reviewed changes
lib/python/qmk/path.py Outdated Show resolved Hide resolved
Erovia
Erovia reviewed Feb 16, 2020
View reviewed changes
lib/python/qmk/path.py Outdated Show resolved Hide resolved
@Curry Curry force-pushed the 7884_cformat branch 2 times, most recently from 0798d3a to 51e2b1d Compare February 18, 2020 00:32
@Curry Curry force-pushed the 7884_cformat branch 5 times, most recently from 02da507 to 71931a4 Compare February 18, 2020 19:11
@Curry
New functionality for cformat
ed106b6 
Fixing complexity

remove lambda

PR review fixes #1

Removing unneccesary string substitution

Handle -a and specified files

Complexity rewrite, use pathlib
@Erovia Erovia requested a review from a team February 18, 2020 21:14
@skullydazed skullydazed merged commit b353028 into qmk:master Feb 23, 2020
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Feb 25, 2020
@Shinichi-Ohki
Merge branch 'master' of https://github.com/qmk/qmk_firmware
034c505 
* 'master' of https://github.com/qmk/qmk_firmware: (108 commits)
  `send_unicode_string()`: Add support for code points > 0xFFFF (qmk#8236)
  [Keyboard] Add Wete (qmk#8229)
  Improvements to extrakey HID descriptors (qmk#8156)
  Hineybush h87a lock indicators (qmk#8237)
  Add VIA support for Prime_L (qmk#8233)
  Hub16 - Bug removal + clean up code (qmk#8227)
  [Keyboard] ai03 Equinox (qmk#8224)
  [Keyboard] Add zfrontier/big_switch (qmk#8205)
  Gingham Update (qmk#8225)
  A proper `send_string()` for the Unicode feature (qmk#8155)
  Rollback PR qmk#7967 in preference of fixing I2C start/stop properly, in a followup PR. (qmk#8173)
  Add mouse support to SEND_STRING (qmk#8223)
  Add link to "Useful functions" in macro docs (qmk#7446)
  New functionality for cformat (qmk#7893)
  Update main.c (qmk#8198)
  format code according to conventions [skip ci]
  Fix QWIIC OLED for AVR (qmk#7769)
  VIA Support: KBD75 rev1/rev2 (qmk#8214)
  Update TMOv2 for new key (qmk#7759)
  Added custom keymap for preonic (qmk#7548)
  ...
nesth pushed a commit to nesth/qmk_firmware that referenced this pull request Feb 27, 2020
Merge remote-tracking branch 'upstream/master'
1362dc4 
* upstream/master: (26 commits)
  Fixed OS detection such that OSX doesn't take over the world (qmk#8248)
  [Keyboard] Add Prime_EXL Plus to handwired (qmk#8238)
  format code according to conventions [skip ci]
  New feature: PERMISSIVE_HOLD_PER_KEY (qmk#7994)
  Split - Avoid race condition during matrix_init_quantum (qmk#8235)
  Acheron VIA support (qmk#8204)
  `send_unicode_string()`: Add support for code points > 0xFFFF (qmk#8236)
  [Keyboard] Add Wete (qmk#8229)
  Improvements to extrakey HID descriptors (qmk#8156)
  Hineybush h87a lock indicators (qmk#8237)
  Add VIA support for Prime_L (qmk#8233)
  Hub16 - Bug removal + clean up code (qmk#8227)
  [Keyboard] ai03 Equinox (qmk#8224)
  [Keyboard] Add zfrontier/big_switch (qmk#8205)
  Gingham Update (qmk#8225)
  A proper `send_string()` for the Unicode feature (qmk#8155)
  Rollback PR qmk#7967 in preference of fixing I2C start/stop properly, in a followup PR. (qmk#8173)
  Add mouse support to SEND_STRING (qmk#8223)
  Add link to "Useful functions" in macro docs (qmk#7446)
  New functionality for cformat (qmk#7893)
  ...
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Mar 5, 2020
@Curry @HokieGeek
New functionality for cformat (qmk#7893)
de290cf 
Fixing complexity

remove lambda

PR review fixes qmk#1

Removing unneccesary string substitution

Handle -a and specified files

Complexity rewrite, use pathlib
c0psrul3 pushed a commit to c0psrul3/qmk_firmware that referenced this pull request Mar 23, 2020
@Curry @c0psrul3
New functionality for cformat (qmk#7893)
5232472 
Fixing complexity

remove lambda

PR review fixes qmk#1

Removing unneccesary string substitution

Handle -a and specified files

Complexity rewrite, use pathlib
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Mar 26, 2020
@Curry @drashna
New functionality for cformat (qmk#7893)
f4b460c 
Fixing complexity

remove lambda

PR review fixes #1

Removing unneccesary string substitution

Handle -a and specified files

Complexity rewrite, use pathlib
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request Apr 2, 2020
@Curry @sowbug
New functionality for cformat (qmk#7893)
94c3317 
Fixing complexity

remove lambda

PR review fixes qmk#1

Removing unneccesary string substitution

Handle -a and specified files

Complexity rewrite, use pathlib
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@Curry @kujawakk
New functionality for cformat (qmk#7893)
3088671 
Fixing complexity

remove lambda

PR review fixes qmk#1

Removing unneccesary string substitution

Handle -a and specified files

Complexity rewrite, use pathlib
jakeisnt pushed a commit to jakeisnt/qmk_firmware that referenced this pull request Aug 20, 2020
@Curry @jakeisnt
New functionality for cformat (qmk#7893)
eb2cba3 
Fixing complexity

remove lambda

PR review fixes qmk#1

Removing unneccesary string substitution

Handle -a and specified files

Complexity rewrite, use pathlib
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@Curry
New functionality for cformat (qmk#7893)
78db7b6 
Fixing complexity

remove lambda

PR review fixes qmk#1

Removing unneccesary string substitution

Handle -a and specified files

Complexity rewrite, use pathlib
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erovia Erovia Erovia approved these changes

@skullydazed skullydazed skullydazed approved these changes

Assignees
No one assigned
Labels
cli qmk cli command python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add change detection to qmk cformat
3 participants
@Curry @Erovia @skullydazed