Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Prime_EXL Plus to handwired #8238

Merged
merged 24 commits into from
Feb 25, 2020
Merged

Add Prime_EXL Plus to handwired #8238

merged 24 commits into from
Feb 25, 2020

Conversation

holtenc
Copy link
Contributor

@holtenc holtenc commented Feb 24, 2020

Add Prime_EXL Plus to handwired

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

noroadsleft
noroadsleft requested changes Feb 24, 2020
View reviewed changes
keyboards/handwired/prime_exl_plus/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/prime_exl_plus/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/prime_exl_plus/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/prime_exl_plus/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/prime_exl_plus/prime_exl_plus.h Outdated Show resolved Hide resolved
keyboards/handwired/prime_exl_plus/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/prime_exl_plus/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/prime_exl_plus/info.json Outdated Show resolved Hide resolved
keyboards/handwired/prime_exl_plus/info.json Outdated Show resolved Hide resolved
keyboards/handwired/prime_exl_plus/info.json Outdated Show resolved Hide resolved
holtenc and others added 11 commits February 24, 2020 15:52
@holtenc @noroadsleft
Update keyboards/handwired/prime_exl_plus/readme.md
eb3c192 
Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>
@holtenc @noroadsleft
Update keyboards/handwired/prime_exl_plus/readme.md
2e2de83 
Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>
@holtenc @noroadsleft
Update keyboards/handwired/prime_exl_plus/readme.md
14aec00 
Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>
@holtenc @noroadsleft
Update keyboards/handwired/prime_exl_plus/rules.mk
e369698 
Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>
@holtenc @noroadsleft
Update keyboards/handwired/prime_exl_plus/info.json
4f7df3f 
Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>
@holtenc @noroadsleft
Update keyboards/handwired/prime_exl_plus/info.json
f1f2d1c 
Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>
@holtenc @noroadsleft
Update keyboards/handwired/prime_exl_plus/info.json
56e9c99 
Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>
@holtenc
Update keymap.c
97a8556
@holtenc
Merge branch 'master' of https://github.com/holtenc/qmk_firmware
1de6a36
@holtenc
correct spacing of keymaps and layout macro. move indicator logic fro…
8dc7605 
…m user space to keyboard space
@holtenc
further corrections to keymaps and layout macro.
f69069f
@holtenc
Copy link
Contributor Author

holtenc commented Feb 25, 2020

requested changes completed

holtenc and others added 5 commits February 24, 2020 23:54
@holtenc @noroadsleft
Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c
e853390 
Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>
@holtenc @noroadsleft
Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c
6bc9866 
Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>
@holtenc @noroadsleft
Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c
93ecdbb 
Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>
@holtenc @noroadsleft
Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c
3ecf2a0 
Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>
@holtenc
Update prime_exl_plus.c
f1d88fd
@holtenc
Copy link
Contributor Author

holtenc commented Feb 25, 2020

done

@noroadsleft noroadsleft requested a review from a team February 25, 2020 06:35
@noroadsleft noroadsleft merged commit d52cd88 into qmk:master Feb 25, 2020
@noroadsleft
Copy link
Member

Thanks!

nesth pushed a commit to nesth/qmk_firmware that referenced this pull request Feb 27, 2020
Merge remote-tracking branch 'upstream/master'
1362dc4 
* upstream/master: (26 commits)
  Fixed OS detection such that OSX doesn't take over the world (qmk#8248)
  [Keyboard] Add Prime_EXL Plus to handwired (qmk#8238)
  format code according to conventions [skip ci]
  New feature: PERMISSIVE_HOLD_PER_KEY (qmk#7994)
  Split - Avoid race condition during matrix_init_quantum (qmk#8235)
  Acheron VIA support (qmk#8204)
  `send_unicode_string()`: Add support for code points > 0xFFFF (qmk#8236)
  [Keyboard] Add Wete (qmk#8229)
  Improvements to extrakey HID descriptors (qmk#8156)
  Hineybush h87a lock indicators (qmk#8237)
  Add VIA support for Prime_L (qmk#8233)
  Hub16 - Bug removal + clean up code (qmk#8227)
  [Keyboard] ai03 Equinox (qmk#8224)
  [Keyboard] Add zfrontier/big_switch (qmk#8205)
  Gingham Update (qmk#8225)
  A proper `send_string()` for the Unicode feature (qmk#8155)
  Rollback PR qmk#7967 in preference of fixing I2C start/stop properly, in a followup PR. (qmk#8173)
  Add mouse support to SEND_STRING (qmk#8223)
  Add link to "Useful functions" in macro docs (qmk#7446)
  New functionality for cformat (qmk#7893)
  ...
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Mar 5, 2020
@holtenc @HokieGeek
[Keyboard] Add Prime_EXL Plus to handwired (qmk#8238)
d3faba1 
* Add VIA support for Prime_L

* Update keyboards/primekb/prime_l/v1/config.h

* Add prime_exl_plus keyboard

* Temporary removal of prime_exl_plus

* Add Prime_EXL Plus, including VIA support

* Update keyboards/handwired/prime_exl_plus/readme.md

* Update keyboards/handwired/prime_exl_plus/readme.md

* Update keyboards/handwired/prime_exl_plus/readme.md

* Update keyboards/handwired/prime_exl_plus/rules.mk

* Update keyboards/handwired/prime_exl_plus/info.json

* Update keyboards/handwired/prime_exl_plus/info.json

* Update keyboards/handwired/prime_exl_plus/info.json

* Update keymap.c

* correct spacing of keymaps and layout macro. move indicator logic from user space to keyboard space

* further corrections to keymaps and layout macro.

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update prime_exl_plus.c

* small edit to prime_exl_plus.c
c0psrul3 pushed a commit to c0psrul3/qmk_firmware that referenced this pull request Mar 23, 2020
@holtenc @c0psrul3
[Keyboard] Add Prime_EXL Plus to handwired (qmk#8238)
b8d089d 
* Add VIA support for Prime_L

* Update keyboards/primekb/prime_l/v1/config.h

* Add prime_exl_plus keyboard

* Temporary removal of prime_exl_plus

* Add Prime_EXL Plus, including VIA support

* Update keyboards/handwired/prime_exl_plus/readme.md

* Update keyboards/handwired/prime_exl_plus/readme.md

* Update keyboards/handwired/prime_exl_plus/readme.md

* Update keyboards/handwired/prime_exl_plus/rules.mk

* Update keyboards/handwired/prime_exl_plus/info.json

* Update keyboards/handwired/prime_exl_plus/info.json

* Update keyboards/handwired/prime_exl_plus/info.json

* Update keymap.c

* correct spacing of keymaps and layout macro. move indicator logic from user space to keyboard space

* further corrections to keymaps and layout macro.

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update prime_exl_plus.c

* small edit to prime_exl_plus.c
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request Apr 2, 2020
@holtenc @sowbug
[Keyboard] Add Prime_EXL Plus to handwired (qmk#8238)
f445914 
* Add VIA support for Prime_L

* Update keyboards/primekb/prime_l/v1/config.h

* Add prime_exl_plus keyboard

* Temporary removal of prime_exl_plus

* Add Prime_EXL Plus, including VIA support

* Update keyboards/handwired/prime_exl_plus/readme.md

* Update keyboards/handwired/prime_exl_plus/readme.md

* Update keyboards/handwired/prime_exl_plus/readme.md

* Update keyboards/handwired/prime_exl_plus/rules.mk

* Update keyboards/handwired/prime_exl_plus/info.json

* Update keyboards/handwired/prime_exl_plus/info.json

* Update keyboards/handwired/prime_exl_plus/info.json

* Update keymap.c

* correct spacing of keymaps and layout macro. move indicator logic from user space to keyboard space

* further corrections to keymaps and layout macro.

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update prime_exl_plus.c

* small edit to prime_exl_plus.c
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@holtenc @kujawakk
[Keyboard] Add Prime_EXL Plus to handwired (qmk#8238)
c18654f 
* Add VIA support for Prime_L

* Update keyboards/primekb/prime_l/v1/config.h

* Add prime_exl_plus keyboard

* Temporary removal of prime_exl_plus

* Add Prime_EXL Plus, including VIA support

* Update keyboards/handwired/prime_exl_plus/readme.md

* Update keyboards/handwired/prime_exl_plus/readme.md

* Update keyboards/handwired/prime_exl_plus/readme.md

* Update keyboards/handwired/prime_exl_plus/rules.mk

* Update keyboards/handwired/prime_exl_plus/info.json

* Update keyboards/handwired/prime_exl_plus/info.json

* Update keyboards/handwired/prime_exl_plus/info.json

* Update keymap.c

* correct spacing of keymaps and layout macro. move indicator logic from user space to keyboard space

* further corrections to keymaps and layout macro.

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update prime_exl_plus.c

* small edit to prime_exl_plus.c
jakeisnt pushed a commit to jakeisnt/qmk_firmware that referenced this pull request Aug 20, 2020
@holtenc @jakeisnt
[Keyboard] Add Prime_EXL Plus to handwired (qmk#8238)
4b1952a 
* Add VIA support for Prime_L

* Update keyboards/primekb/prime_l/v1/config.h

* Add prime_exl_plus keyboard

* Temporary removal of prime_exl_plus

* Add Prime_EXL Plus, including VIA support

* Update keyboards/handwired/prime_exl_plus/readme.md

* Update keyboards/handwired/prime_exl_plus/readme.md

* Update keyboards/handwired/prime_exl_plus/readme.md

* Update keyboards/handwired/prime_exl_plus/rules.mk

* Update keyboards/handwired/prime_exl_plus/info.json

* Update keyboards/handwired/prime_exl_plus/info.json

* Update keyboards/handwired/prime_exl_plus/info.json

* Update keymap.c

* correct spacing of keymaps and layout macro. move indicator logic from user space to keyboard space

* further corrections to keymaps and layout macro.

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update prime_exl_plus.c

* small edit to prime_exl_plus.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@holtenc @noroadsleft @fauxpark