Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid StackOverflowError (fixes LOGBACK-1454) #515

Merged
merged 1 commit into from
Aug 18, 2021

Conversation

jpstotz
Copy link
Contributor

@jpstotz jpstotz commented Mar 5, 2021

by Exceptions that build loops via nested Exceptions in getCause()/getSuppressed()

I also removed some code only required for Java 6 and older which is no longer supported.

Fixes https://jira.qos.ch/browse/LOGBACK-1454

@jpstotz
Copy link
Contributor Author

jpstotz commented Mar 5, 2021

@ceki Don't you think it would be a good idea to process the fix me text that has been added in 2019 which breaks compilation?
https://github.com/qos-ch/logback/blame/master/logback-classic/src/main/java/ch/qos/logback/classic/model/processor/ContextNameModelHandler.java#L25

Having a continuous integration only makes sense if the code is compliable, do you agree?

@ceki ceki merged commit 2cbeb9c into qos-ch:master Aug 18, 2021
@wpanas
Copy link

wpanas commented Jan 24, 2022

@ceki I wonder if this can be fixed for 1.2.x. Right now 1.3.x is unsupported for Spring Boot. What do you think? If you agree, I can prepare a pull request.

@wpanas
Copy link

wpanas commented Jan 28, 2022

As far as I see, it's addressed in #535

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants