-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport fix for LOGBACK-1027 from 1.3.x. #535
Conversation
Signed-off-by: Mario Ellebrecht <mario@ellebrecht.com>
e07a960
to
b49c15b
Compare
@@ -29,59 +32,52 @@ | |||
int commonFrames; | |||
private ThrowableProxy cause; | |||
private ThrowableProxy[] suppressed = NO_SUPPRESSED; | |||
private final Set<Throwable> alreadyProcessedSet; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this field looks useless.
@ceki could you merge this? logback 1.2.6 is currently in production and LOGBACK-1027 hurts us a lot. |
Also asking for merge, affects our production as well. |
Hi 👋 ! I would be more than happy to help if possible 👍 |
Same here really want this to be merged in |
@ceki +1 for backport and merge. It's very disappointing that such an issue is not fixed in current stable branch |
Given the large number of issues that must be attended do, you are welcome to sponsor any bug fix or feature. Please see feature/bug sponsorship. |
Nice price for backport, but I've got your point ;) |
Can this be merged? |
@ceki getting back to business - so how much in total it'd cost to get this back port merged properly and push new version to maven central? Just one of mentioned packages (any? Largest?) or both? |
@ceki sorry for being boring but I just want to better understand is there any timelines for merging this exact fix and doing For example some clear statement like below would be totally fine for me:
where 2 month are just for example here. |
Is it possible to partially sponsor this? I won't be able to convice my company to make a one-time payment, but I could send a few bucks on my own. And I guess others here could contribute to the $800 goal too! Together we could afford it, don't we? |
This PR removes the compatibility layer with Java 1.6 with no mention of the removal. This PR, were it applied as is, would break software running under Java 1.6. |
Fixed in 1.2.11 released earlier today. |
For users of Logback 1.2.x suffering from LOGBACK-1027, provide a solution by backporting the fix from the master branch.