fix(commit, MetadataEditor): fix meta editing and the flow after you commit #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramfox
force-pushed
the
commit-flow-fix
branch
4 times, most recently
from
60707ae
to
0e3878c
Compare
…commit Adjust the `saveWorkingDatasetAndFetch` and `Commit` components, along with the `mutations` reducer and actions to fix the flow after you commit. We need to wait for both the commit to be successful and for the history list to update, inorder to show the user a clean commit experience. To do that, we've added a `saveComplete`/`SAVE_COMPLETE` action to the `mutations` reducer that gets called when save & history fetching is complete Also adjusts the MetadataEditor to fix a content jumping problem
…aset is called Also adds an e2e test to confirm behavior
ramfox
force-pushed
the
commit-flow-fix
branch
from
0e3878c
to
2d56c57
Compare
b5
approved these changes
Jan 17, 2020
Comment on lines
+458
to
+462
| dispatch(setSaveComplete()) | ||
| dispatch(openToast('success', 'commit', 'commit success!')) | ||
| dispatch(setSelectedListItem('commit', path)) | ||
| dispatch(setActiveTab('history')) | ||
| dispatch(setSelectedListItem('commitComponent', DEFAULT_SELECTED_COMPONENT)) |
There was a problem hiding this comment.
hmmm... these are all firing in parallel? Let's examine this in a future PR!
| @@ -206,32 +206,59 @@ describe('Qri End to End tests', function spec () { | |||
| await checkStatus('structure', 'added') | |||
| }) | |||
|
|
|||
| it ('navigate to collection and back to dataset', async () => { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the
saveWorkingDatasetAndFetchandCommitcomponents, along with themutationsreducer and actions to fix the flow after you commit.We need to wait for both the commit to be successful and for the history list to update, inorder to show the user a clean commit experience. To do that, we've added a
saveComplete/SAVE_COMPLETEaction to themutationsreducer that gets called when save & history fetching is completeAlso adjusts the MetadataEditor to fix a content jumping problem
Also, also fixes a bug when navigating to a dataset using the dataset list.
After this pr, e2e tests are passing locally, but not on ci
closes #396