Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(commit, MetadataEditor): fix meta editing and the flow after you commit #394

Merged
merged 2 commits into from
Jan 17, 2020
Merged

fix(commit, MetadataEditor): fix meta editing and the flow after you commit #394

merged 2 commits into from
Jan 17, 2020

Commits on Jan 17, 2020

  1. fix(commit, MetadataEditor): fix meta editing and the flow after you … 

    …commit

Adjust the `saveWorkingDatasetAndFetch` and `Commit` components, along with the `mutations` reducer and actions to fix the flow after you commit.

We need to wait for both the commit to be successful and for the history list to update, inorder to show the user a clean commit experience. To do that, we've added a `saveComplete`/`SAVE_COMPLETE` action to the `mutations` reducer that gets called when save & history fetching is complete

Also adjusts the MetadataEditor to fix a content jumping problem
    @ramfox
    ramfox committed Jan 17, 2020
    Configuration menu
    Copy the full SHA
    a87b19f View commit details
    Browse the repository at this point in the history

  2. fix(setWorkingDataset): don't clear workingDataset when setWorkingDat… 

    …aset is called

Also adds an e2e test to confirm behavior
    @ramfox
    ramfox committed Jan 17, 2020
    Configuration menu
    Copy the full SHA
    2d56c57 View commit details
    Browse the repository at this point in the history