Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Array Output Resize #307

Merged
merged 4 commits into from
Feb 23, 2023
Merged

Fix Array Output Resize #307

merged 4 commits into from
Feb 23, 2023

Conversation

davidkircos
Copy link
Collaborator

Fixes #281

@aws-amplify-us-west-2
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-307.de5w5iglj13on.amplifyapp.com

@davidkircos davidkircos marked this pull request as ready for review February 23, 2023 03:35
Copy link
Collaborator

@jimniels jimniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

One thing, though i'm not sure if it's related to these changes (or perhaps the updated example files PR)?

When I go "File > Open sample > Expenses" and go to change a value, it doesn't redraw at all:

Feb-23-2023 11-33-46

However, if i go in and edit the code that draws that table (add a blank line), save and run it, then change the filter value, now it works as expected.

Feb-23-2023 11-32-07

I still don't totally understand how cell dependencies work, but seems like the dependency array in the sample files have to be updated for this change to take effect?

@davidkircos
Copy link
Collaborator Author

@jimniels I think that is an example files issue. I'll merge the examples PR first and check if it fixes it in this branch.

@davidkircos davidkircos requested a review from jimniels February 23, 2023 19:39
Copy link
Collaborator

@jimniels jimniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, that seemed to fix it 👍

@davidkircos davidkircos merged commit dfeff55 into main Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Python Doesn't Clear Previous Cells Correctly with DataFrame
2 participants