Kodiak PCIe phy refclk always on changes#29
Closed
krishnachaitanya-linux wants to merge 3 commits intoqualcomm-linux:tech/bus/pci/phyfrom
Closed
Kodiak PCIe phy refclk always on changes#29krishnachaitanya-linux wants to merge 3 commits intoqualcomm-linux:tech/bus/pci/phyfrom
krishnachaitanya-linux wants to merge 3 commits intoqualcomm-linux:tech/bus/pci/phyfrom
Conversation
…property Document qcom,refclk-always-on property which is needed in some platforms to supply refclk even in PCIe low power states. Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> Link: https://lore.kernel.org/lkml/20231127-refclk_always_on-v3-1-26d969fa8f1d@quicinc.com/
…fset Some platforms needs to keep endpoint refclk always on, for this purpose add this offset for all the applicable phy versions. And also add reg layout for few controllers as we are adding endpoint refclk control register which changes based upon phy version. Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Link: https://lore.kernel.org/lkml/20231127-refclk_always_on-v3-2-26d969fa8f1d@quicinc.com/
In PCIe low power states like L1.1 or L1.2 the phy will stop supplying refclk to endpoint. If endpoint asserts clkreq to bring back link L0, then RC needs to provide refclk to endpoint. Some platforms with pcie switch fail to drive the clkreq signal to the host from the endpoints because of the switch board design. Due to that refclk needs to supplied to the endpoint always. Add a flag to keep refclk always supplied to endpoint. Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Link: https://lore.kernel.org/lkml/20231201060928.GK4009@thinkpad/
shashim-quic
reviewed
Jun 3, 2025
Collaborator
shashim-quic
left a comment
shashim-quic
left a comment
There was a problem hiding this comment.
SoB is missing in commit 1. Also place SoB as last line in your commit log.
shashim-quic
reviewed
Jun 3, 2025
Collaborator
shashim-quic
left a comment
shashim-quic
left a comment
There was a problem hiding this comment.
Add SoB line as last line. Link: can be simply moved as first tag.
trsoni
reviewed
Jun 9, 2025
trsoni
left a comment
trsoni
left a comment
There was a problem hiding this comment.
Why the DCO checks give the following warning or error (I am not clear what it is)? quic_ID author is still allowed.
Commit sha: 66f5855, Author: Krishna Chaitanya Chundru, Committer: krishnachaitanya-linux; Expected "Krishna Chaitanya Chundru krishna.chundru@oss.qualcomm.com", but got "Krishna chaitanya chundru quic_krichai@quicinc.com".
trsoni
reviewed
Jun 9, 2025
trsoni
left a comment
trsoni
left a comment
There was a problem hiding this comment.
Why checkpatch has not run here eventhough DCO has failed? Are we not running checkpatch if DCO fails first?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are changes required to keep PCIe link always on.