Add measurement gate. #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
95-martin-orion
requested changes
Jun 30, 2020
| @@ -49,7 +51,7 @@ struct BasicGateFuser final { | |||
| * applied together. Note that gates fused with this method are not | |||
| * multiplied together until ApplyFusedGate is called on the output. | |||
| * @param num_qubits The number of qubits acted on by 'gates'. | |||
| * @param gates The gates to be fused. | |||
| * @param gates The gates to be fused. Gate times should be ordered. | |||
There was a problem hiding this comment.
This is a change from our previous assumptions, correct? re: #74
There was a problem hiding this comment.
Correct. Gates don't get explicitly sorted. So there was a possibility of getting incorrect results for unordered gate times.
95-martin-orion
approved these changes
Jul 6, 2020
|
Thank you for the review. I added a function comment. |
This was referenced Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also cleans up statespace.