-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: split dev requirements out of main requirements.txt #467
refactor: split dev requirements out of main requirements.txt #467
Conversation
This change will likely also require updates to existing documentation to ensure that developers know to install the additional requirements file manually, and to the CI workflows so that tests will pass. |
e83b7f3
to
31e3b72
Compare
Done! I think this is ready for review now :) |
eee7543
to
92e6c49
Compare
Code changes all LGTM. Do you know if this will play nicely with our existing notebooks, though? I have a suspicion that moving the |
People will have to do |
Testing is somewhat inconvenient, given that it requires a qsimcirq release (preferably on test-pypi). Instead, if |
92e6c49
to
f0491cc
Compare
Done! |
Currently, if you try to use a tool like Poetry to specify a dependency on
qsim you end up with the unexpected behavior of your package's version of
black
having to be pinned to same versionqsim
pins in itsrequirements.txt
.This should solve this by splitting development dependencies out of the main dependency file.