refactor: split dev requirements out of main requirements.txt #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@95-martin-orion, what's the status of this? We would like to get this merged and into a point release to unblock some internal tooling improvements. |
|
Looks like this PR went out shortly after I left for a long weekend - reviewing now. |
lovesegfault
force-pushed
the
split-dev-deps-redux
branch
from
a25b078 to
efd43e0
Compare
lovesegfault
force-pushed
the
split-dev-deps-redux
branch
from
efd43e0 to
8503958
Compare
95-martin-orion
approved these changes
Mar 14, 2022
| @@ -17,6 +17,12 @@ Prerequisites are included in the | |||
| [`requirements.txt`](https://github.com/quantumlib/qsim/blob/master/requirements.txt) | |||
| file, and will be automatically installed along with qsimcirq. | |||
|
|
|||
| If you'd like to develop qsimcirq, a separate set of dependencies are includes | |||
There was a problem hiding this comment.
[No change needed] Thanks for including a docs note!
|
Release pipeline seems happy with this one. Thanks @lovesegfault for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-try of #467 since it has come up as an issue again.
Hopefully this time I managed to fix the release workflow correctly.